Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hitomi.ImageUriResolver is not defined @8.0.0 #54

Closed
Hastile opened this issue Jan 10, 2024 · 3 comments · Fixed by #55
Closed

hitomi.ImageUriResolver is not defined @8.0.0 #54

Hastile opened this issue Jan 10, 2024 · 3 comments · Fixed by #55
Assignees
@H2Owater425
Labels
bug Something isn't working

Comments

@Hastile
Copy link

Hastile commented Jan 10, 2024

const hitomi = require('node-hitomi').default;

PS C:\Download\hitomi> node index.js
[class (anonymous)] // console.log(hitomi.ImageUrlResolver); @7.0.6

PS C:\Download\hitomi> node index.js
undefined // console.log(hitomi.ImageUrlResolver); @8.0.0
@Hastile Hastile added the bug Something isn't working label Jan 10, 2024
@H2Owater425 H2Owater425 self-assigned this Jan 10, 2024
H2Owater425 added a commit that referenced this issue Jan 10, 2024
@H2Owater425
fix: Fix ImageUriResolver export (#54)
01dd972
@H2Owater425 H2Owater425 mentioned this issue Jan 10, 2024
Merged
H2Owater425 added a commit that referenced this issue Jan 10, 2024
@H2Owater425
Merge pull request #55 from H2Owater425/develop
ff75838 
fix: Fix ImageUriResolver export (#54)
@H2Owater425
Copy link
Owner

Although I fixed the export, it seems like there is an issue with ImageUriResolver.
Please wait until issue #56 is resolved, sorry for the inconvenience.

@Hastile
Copy link
Author

Hastile commented Jan 10, 2024

Its strange that my chrome is throwing 403 when I paste url ImageUriResolver created.

@H2Owater425
Copy link
Owner

Please check #52 for 403 error @Hastile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@H2Owater425 H2Owater425

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix ImageUriResolver export (#54) H2Owater425/node-hitomi
2 participants
@H2Owater425 @Hastile