Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idle Dim Settings not respected/saved #103

Open
marc-gist opened this issue Jan 2, 2023 · 2 comments
Open

Idle Dim Settings not respected/saved #103

marc-gist opened this issue Jan 2, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@marc-gist
Copy link

marc-gist commented Jan 2, 2023

Version of the custom_component

Latest version as of today, and lates opeHasp firmware as of today.

Configuration

N/A

Describe the bug

When you add a plate to HA, de-select the dim when idle setting, add the device to your configuration.yaml file, restart HA. Everything comes up fine, however, the panel still dims on idle, and turns off on long idle! Checking the setting in HA, the checkbox for dim is selected. Uncheck, click save, HA reports setting saved, but when you check the box is selected again and the panel still dims on idle.

unfortunately makes this integration unusable :(

Dim on idle should be handled by automations! so a sensor for idle should be added and used ideally. or just remove this "feature" for now.

Thanks!

Debug log

N/A

@fvanroie
Copy link
Collaborator

fvanroie commented Apr 9, 2023

It seems Config Flow is only for initial setup. To allow the configuration to be changed later, Options Flow also needs to be implemented:
https://community.home-assistant.io/t/configflowhandler-and-optionsflowhandler-managing-the-same-parameter/365582

There also needs to be a setting to disable this in the CC, so users can implement other means like nodeRED, automations or proximity sensors, ...

@htvekov
Copy link

htvekov commented Apr 19, 2023

Yes, we need to be able to disable the different idle events individually or just globally.

I'm fiddling with a custom code proximity sensor implementation and needed a solution for this.
So I've made a crude openHASP CC light.py hack to identity a single openHASP nodename and exclude idle off events specifically for this single device only.

image

@fvanroie fvanroie added the bug Something isn't working label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants