From ad11325a69ab2a267e963b9045b6c6732b14f53b Mon Sep 17 00:00:00 2001
From: Klaus Richarz <kr@hbt.de>
Date: Wed, 15 Jun 2022 12:06:19 +0200
Subject: [PATCH] #141 extend options to 24 hours and optimize code

---
 src/main/java/org/tb/common/DateTimeViewHelper.java | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/tb/common/DateTimeViewHelper.java b/src/main/java/org/tb/common/DateTimeViewHelper.java
index 96ff78407..a33432b63 100644
--- a/src/main/java/org/tb/common/DateTimeViewHelper.java
+++ b/src/main/java/org/tb/common/DateTimeViewHelper.java
@@ -27,6 +27,10 @@
 public class DateTimeViewHelper {
 
   private static final Map<Year, List<OptionItem>> calendarWeeksCache = new HashMap<>();
+  public static final int MAX_TIME_REPORT_HOUR = 24;
+  public static final int MIN_TIME_REPORT_HOUR = 0;
+  public static final int MIN_TIME_REPORT_MINUTE = 0;
+  public static final int MAX_TIME_REPORT_MINUTE = 59;
 
   /*
    * builds up a list of string with current and previous year
@@ -102,7 +106,7 @@ public static List<OptionItem> getBreakHoursOptions() {
    * builds up a list of string with duration hours to display (0-23)
    */
   public static List<OptionItem> getTimeReportHoursOptions() {
-    return getOptionItemListOfInts(0, 23);
+    return getOptionItemListOfInts(MIN_TIME_REPORT_HOUR, MAX_TIME_REPORT_HOUR);
   }
 
   /*
@@ -110,7 +114,7 @@ public static List<OptionItem> getTimeReportHoursOptions() {
    */
   public static List<OptionItem> getTimeReportMinutesOptions(boolean showAllMinutes) {
     if(showAllMinutes) {
-      return getOptionItemListOfInts(0, 59);
+      return getOptionItemListOfInts(MIN_TIME_REPORT_MINUTE, MAX_TIME_REPORT_MINUTE);
     }
     List<OptionItem> result = new ArrayList<>();
     for (int i = 0; i < 60; i+=5) {