From 8e90eeeeb74d1c538d524c36d64dab0ab6454e2e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C3=BChler=20Ma=C3=ABlys?= Date: Thu, 25 Apr 2024 20:47:07 +0200 Subject: [PATCH] change comment --- api/masteriqapp/views/RankView.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/api/masteriqapp/views/RankView.py b/api/masteriqapp/views/RankView.py index 063209f..243c0c6 100644 --- a/api/masteriqapp/views/RankView.py +++ b/api/masteriqapp/views/RankView.py @@ -50,9 +50,10 @@ def global_leaderboard(self, request): @action(detail=True, methods=["GET"]) def user(self, request, pk): - #TODO: ask how to do better?? filter won't be efficient if more element + category = self.category_model.objects.get(pk=pk) ranking = self.iq_model.objects.annotate(row_number=Window(expression=RowNumber(), order_by=F('iq').desc())).filter(category=category).values('iq', 'user_id', 'row_number', 'category_id') + # filter won't be efficient if more element, but not better way to do it found during the project. (Discussed in mail) user_ranking = list(filter(lambda r: r['user_id'] == request.user.id, ranking)) iq = self.iq_model.objects.get(user=request.user, category=category) data_to_send = {"user_rank": user_ranking[0]['row_number'], "user_iq": iq.iq} @@ -60,8 +61,8 @@ def user(self, request, pk): @action(detail=False, methods=["GET"]) def global_user(self, request): - # TODO: ask how to do better?? filter won't be efficient if more element data_with_score = get_user_model().objects.annotate(global_score=Avg('iq__iq'), row_number=Window(expression=RowNumber())).order_by('-global_score') + # filter won't be efficient if more element, but not better way to do it found during the project. (Discussed in mail) user_ranking = list(filter(lambda r: r.id == request.user.id, data_with_score)) data_to_send = {"user_rank": user_ranking[0].row_number, "user_iq": user_ranking[0].global_score} return Response(data=data_to_send, status=status.HTTP_200_OK)