Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Player: actions #6

Open
qtipee opened this issue Nov 6, 2019 · 3 comments
Open

Audio Player: actions #6

qtipee opened this issue Nov 6, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@qtipee
Copy link
Collaborator

qtipee commented Nov 6, 2019

Implementation of the following actions:

  • Next
  • Rewind
  • Previous
  • Repeat
  • Random
@qtipee qtipee self-assigned this Nov 6, 2019
@qtipee
Copy link
Collaborator Author

qtipee commented Nov 9, 2019

The « Next » and « Previous » actions are implemented (see issue #5).

qtipee pushed a commit that referenced this issue Nov 9, 2019
qtipee pushed a commit that referenced this issue Nov 9, 2019
@qtipee
Copy link
Collaborator Author

qtipee commented Nov 9, 2019

A constant defines from which currentTime the « Previous » action rewinds the current audio file (3 seconds) ; when the currentTime is smaller than this constant, the previous audio file is set and then played.

qtipee pushed a commit that referenced this issue Nov 12, 2019
@qtipee
Copy link
Collaborator Author

qtipee commented Nov 12, 2019

A click on the « Random » button plays a random audio file, and keeps playing another random audio file whenever the « on ended » event is triggered. To cancel it, just click on an audio file. Each randomly played audio file is pushed in a history list ; it allows to play back the previous audio files. However, I'm not satisfied with the current behaviour of the « Random » action ; I think it would be better to have something similar to Spotify : the « Random » action is like a checkbox and there is a « Play/Listen » button to start the tracks.

I'm also not satisfied with the code ; it needs to be reviewed, refactored and simplified.

I have spent too much time on this issue ; I'm letting it open and will come back to it as soon as possible to improve the random behaviour and the corresponding code.

@qtipee qtipee added the enhancement New feature or request label Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant