Skip to content
This repository has been archived by the owner on Nov 18, 2020. It is now read-only.

Masker is a duplicate of Subtractor #78

Open
vvolkl opened this issue Dec 6, 2017 · 1 comment
Open

Masker is a duplicate of Subtractor #78

vvolkl opened this issue Dec 6, 2017 · 1 comment
Assignees
@vvolkl

Comments

@vvolkl
Copy link
Member

vvolkl commented Dec 6, 2017

There is not much code duplication because they are small clases, but it could lead to confusion nonetheless. In FCChhAnalyses, only Subtractor is used, so I propose to remove Masker.
@cbernet
Copy link

cbernet commented Jan 31, 2018

Subtractor has been added after Masker, which is more general.
So we should instead keep Masker, and move Subtractor to the FCChh analysis packages.
Could you please let me know when i can do that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vvolkl vvolkl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbernet @vvolkl