Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Python3 #70

wants to merge 2 commits into from

Conversation

redst4r
Copy link

@redst4r redst4r commented Jun 2, 2016

Ported the whole project to python 3 (3.5), extending on #57

  • tests pass (except the five that fail even with the original code and python2).
  • it's still compatible with python 2.7 (/examples/simple, examples/noisy examples/constrained work).
  • the only thing i'm not so confident about is the string-encoding in spearmint/utils/compression.py
    and whether its still neccessary

@redst4r redst4r mentioned this pull request Jun 2, 2016
@redst4r redst4r mentioned this pull request Jun 18, 2016
@1Reinier
Copy link

So is this safe to use now?
When will it be merged?

@redst4r
Copy link
Author

redst4r commented Jul 14, 2016

Didn't get any response from the developers yet.
Also, I didnt have time to use spearmint in some of my projects for some thorough testing

@redst4r
Copy link
Author

redst4r commented Jul 18, 2016

@PhABC : I presume the python setup.py install failed, not running spearmint after install.
Can you show us the actual error you get?
I just tested it with with Python 3.5.1 |Anaconda 4.0.0 (64-bit), and it installed properly

@PhABC
Copy link

PhABC commented Jul 21, 2016

This version works well for me on two of my projects. The only thing, which might not be caused by this version, is that spearmint seems to stop on its own (freeze, not crash) without any error message in the output logs.

@amueller
Copy link

amueller commented Aug 2, 2017

well would be nice to have the devs have a look at this...

@iaroslav-ai
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants