Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoAF origin trial #752

Merged
merged 8 commits into from
Aug 23, 2023
Merged

LoAF origin trial #752

merged 8 commits into from
Aug 23, 2023

Conversation

rviscomi
Copy link
Member

@rviscomi rviscomi commented Jul 6, 2023

According to Search Console, we have an INP problem on our report pages. I think this is a good opportunity to try out the new LoAF origin trial in Chrome 115116 to see if it helps us narrow the problem down. While it might not be necessary for debugging, it's a good opportunity for us to dogfood the API.

I've registered all HA subdomains for the trial and this PR adds the meta token.

image

@rviscomi rviscomi requested a review from tunetheweb July 6, 2023 02:48
@tunetheweb
Copy link
Member

No issues adding but what’s the use case for enabling for everyone given we’re not sending LoAF data to analytics? Or is that planned for a future PR?

I guess at least it enables it without having to enable all the other Experimental Web Platform features?

@rviscomi
Copy link
Member Author

rviscomi commented Jul 6, 2023

Yeah I'd like to also include it in our analytics. I'd need more time to get familiar with it but I can follow that up in a future PR.

@tunetheweb
Copy link
Member

I'm also supposed to be writing a blog post on LoAF. In which I should consider questions like this! :-)

@rviscomi
Copy link
Member Author

rviscomi commented Jul 6, 2023

Looking forward to it! At least in our case, since we already have real-user INP issues, it'd be really interesting to see how that maps back to the real-user LoAF diagnostics. Setting the flag locally is probably good enough for most curious people.

@rviscomi
Copy link
Member Author

rviscomi commented Jul 6, 2023

Not sure if it's too bleeding edge for web-vitals.js, but I filed a FR to add LoAF support to the attribution build: GoogleChrome/web-vitals#363

@rviscomi
Copy link
Member Author

Working on this actually helped uncover a gap in the API: https://bugs.chromium.org/p/chromium/issues/detail?id=1473663 🙌

config/last_updated.json Outdated Show resolved Hide resolved
src/js/send-web-vitals.js Outdated Show resolved Hide resolved
@rviscomi rviscomi merged commit 0715e9f into main Aug 23, 2023
5 checks passed
@rviscomi rviscomi deleted the loaf-ot branch August 23, 2023 20:43
@rviscomi
Copy link
Member Author

rviscomi commented Aug 23, 2023

Deployed live and the LoAF data appears to be successfully flowing
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants