Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a status to keep track of GPS conditions? #90

Open
sunsheeppoplar opened this issue Apr 5, 2017 · 1 comment
Open

Create a status to keep track of GPS conditions? #90

sunsheeppoplar opened this issue Apr 5, 2017 · 1 comment
Labels

Comments

@sunsheeppoplar
Copy link
Contributor

sunsheeppoplar commented Apr 5, 2017

Right now we're already scraping players who meet some conditions we can't quite deal with properly.

  • players who have a nationality but no transfermarkt POB
  • players who have POB and nationality but perhaps are from somewhere even a secondary API wouldn't cover (see Serie A - No Google Maps Responses #89)

For former we return just a GPS coordinate of the "center of country" from Google. One way to alleviate this since this data set is low is to report birth place from wiki and team profile page?

Does this warrant moving location info into own mode as we have other data now crowding player model (see #80)

@sunsheeppoplar
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant