-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iframe page for embedding in 3rd party websites #283
Comments
I am working on this. Didn't see how to assign to myself. |
* Adds new routes in routes.rb get 'region/*regionname', to: 'region#index' get 'region-results', to: 'regionsubmissions#result_page', as: :regionresult_page get 'regionresult/:test_id', to: 'regionsubmissions#show', as: :regionsubmission * Adds new route page with the following folders /app/views/region /app/views/regionshared /app/views/regionsubmissions * Adds animated images for regions (not visible yet) /app/assets/images/take_the_test-animated3.gif /app/assets/images/view_results-animated3.gif * Usage <iframe src="https://speedupamerica.com/region/Oregon" width="1000" height="500"></iframe> <iframe src="https://speedupamerica.com/region/New%20York" width="1000" height="500"></iframe> <iframe src="https://speedupamerica.com/region/Quebec" width="1000" height="500"></iframe> <iframe src="https://speedupamerica.com/region/Mexico" width="1000" height="500"></iframe>
#283 iframe page for embedding in 3rd party websites
* Update form steps * Break out assets to not interfere with main site test * Add styling and functionality for theming regions * Duplicate speed tests for regions
#283 Add functionality for Regional iFrame site
…r California for regions
#283 Allow Uppercase or lowercase for Oregon, Washington or Californi…
* Data now inputting to new tables * Show results page * Export data * Updates to styles
#283 iframe page for embedding in 3rd party websites
…tinued * Remark out region_submission.populate_boundaries which was causing an error - hope this will fix the issue
#283 iframe page for embedding in 3rd party websites - continued
@webaissance a few copy and other minor edits:
|
Okay @mattsayre - I will work on those - give me till tomorrow mid-morning and I'll send these updates through. |
* Remove the copy "Test Your Internet Speed Oregon" * Remove the copy "In 5 Steps" * Remove csv Export button from iframe, just need to know the direct link URL.
#283 iframe page for embedding in 3rd party websites
Additional minor edits @webaissance :
|
Additional minor edit @webaissance
|
Ok. I'll work on sending another PR tomorrow or tonight if possible
…On Tue, Apr 26, 2022, 9:50 PM Matt Sayre ***@***.***> wrote:
Additional minor edit @webaissance <https://github.com/webaissance>
1. we need to change the language under the "I don't have internet"
track, when they enter their address. The copy should be replaced with "I'd
like to register my address as a location that doesn't have internet".
—
Reply to this email directly, view it on GitHub
<#283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAURRHZUG6Z3IODSATMSXDVHDBRTANCNFSM5NNLMY6A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
* Remove the question about connection type (wired/wifi/cellular) in its entirety. * Change Estimated price per month question to OPTIONAL. * Remove csv Export button from iframe, just need to know the direct link URL. * Make question 3 (regarding price), optional. This will require the additional change of having question 4 come up to fill out in tandem with question 3. * The "i" hover over in question 3 floats up and is getting cut off (readability). Needs to float down, which should prevent the text from being cutoff. * Remove entire statement on results page, "This test helps...". * we need to change the language under the "I don't have internet" track, when they enter their address. The copy should be replaced with "I'd like to register my address as a location that doesn't have internet".
Matt - I just sent a PR that takes care of all of the remaining tasks for
the iFrame issue.
Also - of note - in order to download data you have to inspect the result
page and unhide the button. I don't know of a way to trigger the
export just via a URL.
The export process can be developed over time more as needed.
Hope tomorrow goes great for the project!
…-Dave
On Tue, Apr 26, 2022 at 9:50 PM Matt Sayre ***@***.***> wrote:
Additional minor edit @webaissance <https://github.com/webaissance>
1. we need to change the language under the "I don't have internet"
track, when they enter their address. The copy should be replaced with "I'd
like to register my address as a location that doesn't have internet".
—
Reply to this email directly, view it on GitHub
<#283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAURRHZUG6Z3IODSATMSXDVHDBRTANCNFSM5NNLMY6A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
iframe page for embedding in 3rd party websites #283
@webaissance three additional minor edits:
|
@mattsayre I am working on these. I would say anything that's just cosmetic or type change is minor. Anything that changes functionality is small but not minor - because it changes the logic and has the potential to break things and therefore requires more thorough testing. In any case - I will try to get these done asap and send through a PR. |
For 1) - the new Opt-in item - we should probably add this as a database field - for opt-in right? This would involve running the db migrator update again. |
Related to this - wouldn't each region have it's own disclaimer - so the link shouldn't be hardcoded in - but a configuration for each region? |
Thank you. Yes, let’s add that later.
… On Apr 29, 2022, at 8:23 AM, Webaissance ***@***.***> wrote:
For 1) - the new Opt-in item - we should probably add this as a database field - for opt-in right? This would involve running the db migrator update again.
For now I will not do that - since this appears to be urgent - but can add it later if needed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Good thinking. Let’s also put that on the future roadmap and just hard code it for now.
… On Apr 29, 2022, at 8:29 AM, Webaissance ***@***.***> wrote:
Related to this - wouldn't each region have it's own disclaimer - so the link shouldn't be hardcoded in - but a configuration for each region?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Okay. And also - the disclaimer link is being hardcoded to the test instance: https://test.fasterinternetoregon.org/disclaimer/ |
*Add second required checkbox on question 1 (have/have not internet). This will replace the passive agreement and associated language which is currently "By entering your information you agree to the data policy." NEW language next to new checkbox "I agree to the data policy https://www.measurementlab.net/privacy/ and have read the disclaimer <disclaimer site https://test.fasterinternetoregon.org/disclaimer/)>. *Remove entirely the price I would pay question, under the click path for "i don't have internet". *Remove the informational "i" in "What is the estimated price..." question, under the click path of "I have internet access at my home".
iframe page for embedding in 3rd party websites #283
@webaissance follow-up to our conversation about restoring IP address lookup capability for naming ISP's. |
@webaissance add Spanish language version of iframe. Copy attached . |
Link to (test) Spanish translation of disclaimer https://test.fasterinternetoregon.org/es/disclaimer/ |
@webaissance - BUG - Scenario where user clicks “I do NOT have internet…”, then “Internet is not affordable”, then register my address… it currently initiates a speed test. There should NOT be a speed test initiated in this flow. |
Okay - what should it do instead? What should the button say?
…On Fri, May 6, 2022 at 8:51 AM Matt Sayre ***@***.***> wrote:
@webaissance <https://github.com/webaissance> - BUG - Scenario where user
clicks “I do NOT have internet…”, then “Internet is not affordable”, then
register my address… it currently initiates a speed test. There should NOT
be a speed test initiated in this flow.
—
Reply to this email directly, view it on GitHub
<#283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAURRHMAOUUZ62EPDNRFZ3VIU5X5ANCNFSM5NNLMY6A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
When user selects "I do NOT have Internet access..." > Internet is not affordable, they should receive this confirmation message (and not initiate the speed test): "Thank you for your participation. Get more information on state and federal government discounted Internet access programs: https://www.oregon.gov/puc/pages/oregon-lifeline.aspx” "Gracias por su participación. Obtenga más información sobre programas del gobierno estatal y federal que ofrecen acceso a Internet con descuento: https://www.oregon.gov/puc/pages/oregon-lifeline.aspx” When user selects "I do NOT have Internet access..." > Internet is not available..., they receive this confirmation message: "Thank you for your participation." |
@mattsayre - I'm not clear on the process flow for different scenarios - particularly if no internet connection. It would nice to have a flowchart of the scenarios. |
@webaissance yes, we do want to collect data from all form submissions (have and have not internet). Flow chart B is very close, made one edit, see attached . |
Thanks @mattsayre - now I'm getting clarity. I made an updated flowchart on SmartDraw.com. It allows us to collaborate on Flowcharts via shared links, I think if we collaborate on flow charts like this it will really help provide clarity and accuracy to the project and we can accelerate our progress. I'm evaluating SmartDraw.com - and also looking at Lucid.co and will evaluate others. If we can leverage some of these amazing tools it will really help! I will be sending a Pull Request that matches this flowchart as soon as I can. |
* add Spanish language version of iframe * Began fix to "BUG - Scenario where user clicks “I do NOT have internet…”, then “Internet is not affordable”, then register my address… it currently initiates a speed test. There should NOT be a speed test initiated in this flow." Submit button doesn't work quite yet - but it doesn't run the speed test and shows the submit button instead. I will hook the button up to the submital functionality next Use https://test.speedupamerica.com/region/Oregon-es or https://test.speedupamerica.com/region/oregon-es to see the Spanish version
iframe page for embedding in 3rd party websites #283
@webaissance additional translation: Your Results = Sus Resultados Download Speed = Velocidad de Descarga Upload Speed = Velocidad de Carga Ping = Ping |
* Scenario where no internet does not run speed test. Instead submits data to database * 3 possible messages: a) Speed Results b) No internet - not affordable c) No internet - no access
iframe page for embedding in 3rd party websites #283
* Change region disclaimer links to Live instead of Test ** https://www.fasterinternetoregon.org/es/disclaimer/ ** https://www.fasterinternetoregon.org/disclaimer/ * Added Provider field to output of Region test and Region CSV export (locally this field is showing up blank. I hope it will get data on the test and live sites) * Added direct path to retrieve Region CSV export: https://speedupamerica.com/region_submissions/region_export_csv_report/
iframe page for embedding in 3rd party websites #283
@webaissance while we work to figure why the 'provider' lookup is not working, let's add IP Address to the csv export, so that it can be derived later in the overall workflow (in the separate analysis tool). |
@webaissance in the CSV export, the significant digits for lat/long appear to be truncating or rounding. Let's work together to ensure that those get read out fully. |
Oh - thanks for catching that. I'll look into fixing it.
…On Thu, May 19, 2022 at 11:05 PM Matt Sayre ***@***.***> wrote:
@webaissance <https://github.com/webaissance> in the CSV export, the
significant digits for lat/long appear to be truncating or rounding. Let's
work together to ensure that those get read out fully.
—
Reply to this email directly, view it on GitHub
<#283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAURRDG4EBY3EMFEJMOFPDVK4TSNANCNFSM5NNLMY6A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
* Add IP Address to regional export
* Remove 2 fields from CSV export: accurracy and connected_with
iframe page for embedding in 3rd party websites #283
Is your feature request related to a problem? Please describe.
Looking to enable 3rd party branded websites to embed a speedup page, in their website. This will be a survey style form, very similar to how it is done on speedupamerica.com proper, meaning a sequence for taking a speed test of geolocation (use my browsers location/use my addres), then Residential/Mobile/Public, connection tyep (wired/wireless/etc), price, advertised speed. Then return speed results and comparison.
Describe the solution you'd like
iframe so that it can be branded by third parties. Only branding inside the frame will be "Powered by SpeedUpAmerica"
Describe alternatives you've considered
Javascript embed
Additional context
Don't need mapping, this feature is simply for collecting crowdsourced speed test results.
Regional Report Link: https://speedupamerica.com/region_submissions/region_export_csv_report/
(added for future reference - @webaissance )
The text was updated successfully, but these errors were encountered: