Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "all" from ISP field after removing previous filter (.5SP) #55

Open
Amcclennahan opened this issue May 1, 2019 · 3 comments
Open

Comments

@Amcclennahan
Copy link
Collaborator

Steps to reproduce:

  1. Select and ISP
  2. Remove selection
  3. See behavior

SC attached -- In all instances where a filter is not selected we want to display the Select Client ISP to View sample text
all liar

@mattsayre mattsayre changed the title Remove "all" from ISP field after removing previous filter Remove "all" from ISP field after removing previous filter (.5SP) Jul 17, 2019
@mattsayre
Copy link
Collaborator

This one is about half way fixed. When you slick the X in the filter next to the word All, the map should not render and the filter field should say "Select an ISP".

@khutchison
Copy link
Collaborator

Is this still an issue? right now if you click x on All, it simply reloads the map and All remains.

I think either - "make All unremovable/don't reload the map when X is clicked on all"
or Matt's proposed "stop the map from rendering and display 'Select an ISP' filler text" would work. Thoughts on which one creates a better UX?

@alexandracorvello
Copy link

I think having the default as All is the better user experience because visually it is more interactive from the start instead of being confronted with a blank map.

Another issue with the map is some typos:

  1. as you can see in the screenshot above it the legend says "Download Speed", this should just say "Internet Speed" because you can view both upload and download speeds on the map.

  2. When you group by Census Tract and click on a tract on the map, the label says "Tact" instead of "Tract".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants