You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2023. It is now read-only.
Components.Type is wrongly used to validate component<->slot matching, but this is wrong, component types should only be used to categorize inventory entries.
No work was done on that before because 99% of the slot types have the same name as the component type, but we'll have to change it in the future.
Proposal
Modify: Components.Type => String
And localize the name using our future translation mechanism.
Add: SlotType, this thing will replace component type for validation.
Reasoning
There are multiple types of HDD slots: sata / nvme, we're not using nvme yet, but we need to prepare for that.
Keep this issue low priority until campaign is almost ready.
The text was updated successfully, but these errors were encountered:
Summary
Components.Type is wrongly used to validate
component<->slot
matching, but this is wrong, component types should only be used to categorize inventory entries.No work was done on that before because 99% of the slot types have the same name as the component type, but we'll have to change it in the future.
Proposal
Reasoning
There are multiple types of HDD slots:
sata
/nvme
, we're not usingnvme
yet, but we need to prepare for that.The text was updated successfully, but these errors were encountered: