Skip to content
This repository has been archived by the owner on Jun 11, 2023. It is now read-only.

Swap Component Type with Slot Type for link valitation #348

Open
chrisfls opened this issue Dec 16, 2017 · 0 comments
Open

Swap Component Type with Slot Type for link valitation #348

chrisfls opened this issue Dec 16, 2017 · 0 comments

Comments

@chrisfls
Copy link
Contributor

chrisfls commented Dec 16, 2017

Summary

Components.Type is wrongly used to validate component<->slot matching, but this is wrong, component types should only be used to categorize inventory entries.

No work was done on that before because 99% of the slot types have the same name as the component type, but we'll have to change it in the future.

Proposal

  • Modify: Components.Type => String
    • And localize the name using our future translation mechanism.
  • Add: SlotType, this thing will replace component type for validation.

Reasoning

There are multiple types of HDD slots: sata / nvme, we're not using nvme yet, but we need to prepare for that.

Keep this issue low priority until campaign is almost ready.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant