Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the /path command in game a private message #2951

Open
CardSwim8 opened this issue Jun 28, 2024 · 11 comments
Open

Make the /path command in game a private message #2951

CardSwim8 opened this issue Jun 28, 2024 · 11 comments

Comments

@CardSwim8
Copy link

Avoid implied table talk by making the /path command and response private

@Zamiell
Copy link
Collaborator

Zamiell commented Jun 28, 2024

do u wanna submit a pr?

@CardSwim8
Copy link
Author

i wish. way outside my skillset :(

@rz-1
Copy link
Contributor

rz-1 commented Jun 28, 2024

I disagree, I think the /path command should stay global b/c it's an easy way to share the doc with newer players.

There is already a way to accomplish this: go to lobby > resources button > Strategies and Conventions url.
If you want to make a separate command that whispers the link to the user that seems fine.

@CardSwim8
Copy link
Author

i feel like we could have our cake and eat it to on this one: make it public in the general chat and in the pre-game chat, but private during live games? probably harder to implement though

@rz-1
Copy link
Contributor

rz-1 commented Jun 28, 2024

Personally, I'd still disagree.
But it's probably feasible to add a parameter to the /path command. Something like:
/path @msg_location <"global"/"msg"> (default would be "global" to keep functionality the same)

Now whether that's worth the time to develop when there's a known workaround is another story.

@Zamiell
Copy link
Collaborator

Zamiell commented Jun 28, 2024

I disagree, I think the /path command should stay global b/c it's an easy way to share the doc with newer players.

i also kind of like it being global because, in the situation where you have 3 max level players playing with 1 level 6 player, now ALL three max level players will have to type /path. whereas now only one of them has to type path and then the other two simply click on the link, if that makes sense.

@CardSwim8
Copy link
Author

i can see reasoning for that. maybe then rz's original suggestion of a /pm_path command or something similar so that people aren't inadvertently influencing others by using the /path command either before giving a clue or immediately after receiving one

@Zamiell
Copy link
Collaborator

Zamiell commented Jun 28, 2024

it's an easy way to share the doc with newer players

well you are supposed to use /doc for that, not /path

@rz-1
Copy link
Contributor

rz-1 commented Jun 28, 2024

well you are supposed to use /doc for that, not /path

then I guess I'm confused, whats the purpose of /path when you can use /doc and then click on "learning path" from the main doc page?

edit: This looks bloat to me, but I have a dedicated tab open to the learning path in my browser and I don't use either command. I think we're getting into a silly territory here, so I'm going to stop arguing.

@Zamiell
Copy link
Collaborator

Zamiell commented Jun 28, 2024

then I guess I'm confused, whats the purpose of /path when you can use /doc and then click on "learning path" from the main doc page?

to prevent having the extra step of having to click on "learning path" from the main doc page

@Zamiell
Copy link
Collaborator

Zamiell commented Jun 28, 2024

This looks bloat to me

yeah having both /doc and /path is probably bloat, but i am fairly lazy in not wanting to click an additional time, so I like it, for now anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants