Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme With Updated Default Versions #193

Closed
wants to merge 1 commit into from

Conversation

alexfinnarn
Copy link

closes #192

Copy link
Collaborator

@jesseshieh jesseshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Why not use the latest versions available here?

Also, the defaults will be removed pretty soon so the comment about defaults may not be necessary.

@alexfinnarn
Copy link
Author

alexfinnarn commented Mar 8, 2021

Why not use the latest versions available here?

I'm not sure where "here" is? Maybe some document...I just updated this PR based on my experience. The latest versions of Elixir and Erlang did not work for my use case, and I spent a bit of time just changing versions and getting further until I had a working app. I have the repo elsewhere if any file will help further.

But if you are removing the defaults and requiring an explicit config file, then I agree with that move. However, if there were no defaults, then I wouldn't have gotten a little farther by removing my custom config files and seeing my issue probably related to version compatibility with my project dependencies.

I do foresee people with different projects trying to use the same "default versions" mentioned in a readme or file, failing the build, and then giving up. At least that was my experience. So, that's why I wanted to add a note to the potential future me to "not give up until you've played around with versions. Look at X to guide you" with X being the supported versions section.

Of course, you might say, "that's already in there dude, RTFM." but I guarantee you a lot of devs will not read the whole thing and skip around to the config file options. I tend to try and over document things, if that makes sense.

@jesseshieh
Copy link
Collaborator

This shouldn't be needed now that we are removing default versions here
#209

@jesseshieh jesseshieh closed this Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Readme With Updated Default Versions
2 participants