Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: WalletConnect gets stuck on multiple proposal flow #1849

Open
plor opened this issue May 23, 2022 · 7 comments
Open

Bug: WalletConnect gets stuck on multiple proposal flow #1849

plor opened this issue May 23, 2022 · 7 comments
Labels
backlog bug Something isn't working

Comments

@plor
Copy link
Contributor

plor commented May 23, 2022

https://www.loom.com/share/9194fd0bf84d4723a126636d634b153f

The 'Connect Wallet' button gets stuck on Wallet Connect and forces you to connect a wallet through Wallet Connect and then disconnect in order to get the Metamask option back.

Refreshing doesn't fix it either.

When exiting the Wallet Connect modal the 'Connect Wallet' button should offer both Metamask and Wallet Connect options.

@plor plor added the bug Something isn't working label May 23, 2022
@wackerow
Copy link
Contributor

wackerow commented May 24, 2022

Just noticed this as well... switched to WalletConnect to connect with a safe, and then unable to get back to MetaMask.

Closing this and/or hard refreshing came back with WalletConnect as only option again, unable to get back to MetaMask vs WalletConnect options

Clearing the daohaus.club cookie fixed this.

@plor plor moved this from Needs Triage to Ready For Dev in DAOhaus v2: Robot Apartments May 25, 2022
@plor
Copy link
Contributor Author

plor commented May 25, 2022

@brossetti1 let me know if this is clear enough to work off of. I can go through to detail the steps to reproduce if that will help.

@brossetti1
Copy link
Contributor

ill take a look at this one next and let you know if i have any questions

@brossetti1 brossetti1 self-assigned this May 25, 2022
@brossetti1 brossetti1 moved this from Ready For Dev to In Development in DAOhaus v2: Robot Apartments May 25, 2022
@brossetti1
Copy link
Contributor

@plor yeah can you take me through reproduction steps? so far im not able to replicate the issue so far - when I select Wallet Connect or try to connect to a safe minion as in the video, it always rereshes the wallet connection options so metamask or wallet connect are available.

any instructions on this one would be helpful, thanks!

@plor
Copy link
Contributor Author

plor commented Jun 1, 2022

Will do, it is a bit of a tricky one. Lots of back and forth and such.

@brossetti1
Copy link
Contributor

@plor I cannot replicate this one - @santteegt wondering if you know whats going on here?

@plor plor moved this from In Development to Ready For Dev in DAOhaus v2: Robot Apartments Jun 6, 2022
@santteegt
Copy link
Contributor

santteegt commented Jun 7, 2022

Hey @plor @brossetti1!

I was unable to reproduce the error. Did several tests on Chrome, Firefox & Brave. I also did a Dao2Dao proposal using the Minion "Use WalletConnect" feature using the same & different browsers tabs for each instance and never got stuck on WalletConnect when trying to switch wallet providers

@plor plor moved this from Ready For Dev to Needs Triage in DAOhaus v2: Robot Apartments Jul 3, 2022
@plor plor added the backlog label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog bug Something isn't working
Projects
No open projects
Status: Needs Triage
Development

No branches or pull requests

4 participants