You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On the Minion transfer, if you click the max button it reduces some precision for the ERC-20 and rounds up, sometimes resulting in failed transactions.
I've loaded a test DAO with 0.00555555555555 WETH on rinkeby. If you need membership let me know and I'll vote you in (or reproduce yourself).
I believe it is there was about 8724462353742895500000 which is where the issue came from, since it seems to be rounding to 12 decimal places. I'm not sure if it matters that this was WXDAI.
Describe the bug
On the Minion transfer, if you click the max button it reduces some precision for the ERC-20 and rounds up, sometimes resulting in failed transactions.
I've loaded a test DAO with 0.00555555555555 WETH on rinkeby. If you need membership let me know and I'll vote you in (or reproduce yourself).
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Max should transfer exactly what is available in the vault (at correct precision).
Actual behavior
Max button rounds up and exceeds actual max if number after precision cutoff is 5 or higher.
Screenshots
Application area
Where in the app is this happening?
Additional context
Can see original proposal where this came up here: https://app.daohaus.club/dao/0x64/0x046d1c324cd5ca0115e04ea1e4feecfaf44a8bf5/proposals/6
The text was updated successfully, but these errors were encountered: