Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Lit feature flag #1960

Open
plor opened this issue Jul 5, 2022 · 9 comments
Open

Remove Lit feature flag #1960

plor opened this issue Jul 5, 2022 · 9 comments
Assignees

Comments

@plor
Copy link
Contributor

plor commented Jul 5, 2022

#1774 was developed for Lit integration, but they didn't have some API to support it. We merged the code but put it in a feature flag that can be removed once everything is good and working.

relavent pr and comment - #1897 (comment)

@brossetti1
Copy link
Contributor

brossetti1 commented Jul 12, 2022

spoke with Chris at Lit

follow up tasks for our side:

  • add chain to url variables - for v3 modal.
  • generate auth sig on our side and pass as url param
  • pass null in signature on daohaus side, along with switchChains: false.
  • redirect to lit protocol will add the signature into the url button will do this while also the signature we collect on our side.

@plor plor removed the backlog label Jul 13, 2022
@plor
Copy link
Contributor Author

plor commented Jul 13, 2022

Should I separate these into separate issues so we can work piecemeal on it, or are these all just necessary for removing the flag?

@plor plor moved this from Needs Triage to Ready For Dev in DAOhaus v2: Robot Apartments Jul 13, 2022
@brossetti1
Copy link
Contributor

these are all required for removing the flag - lets leave them here. Chris from Lit has to make changes on his end, which prompted these changes here -- there are some small issues with the signature collection on their end, but we worked out a way to make the flow much easier for our users and their users.

We just have to wait on his updates now, i addressed a most of these after our call already

@plor
Copy link
Contributor Author

plor commented Jul 13, 2022

I moved to "ready for dev" so you can start working on the follow up tasks at your leisure, no rush though.

@plor
Copy link
Contributor Author

plor commented Jul 25, 2022

Lit responded Friday, going to finish this up.

@brossetti1 brossetti1 moved this from Ready For Dev to In Development in DAOhaus v2: Robot Apartments Jul 25, 2022
@brossetti1
Copy link
Contributor

looked at finishing this up after recieving some communication back from chris at lit, seems like there are still some issues to be worked out here on lits side - sent a message back to chris on the matter

@brossetti1 brossetti1 moved this from In Development to Ready For Dev in DAOhaus v2: Robot Apartments Jul 25, 2022
@plor
Copy link
Contributor Author

plor commented Jul 25, 2022

can the follow-up tasks be tackled or are we fully blocked?

@brossetti1
Copy link
Contributor

blocked until chris gets back, some things we discussed the other week still have not been addressed, they ar emaking progress, but its still a blocker for us

@plor plor added the blocked label Jul 25, 2022
@plor
Copy link
Contributor Author

plor commented Aug 18, 2022

@brossetti1 any more word from Lit? I'd be happy to try to close this out so you can focus on V3 if that is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Ready For Dev
Development

No branches or pull requests

2 participants