-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Lit feature flag #1960
Comments
spoke with Chris at Lit follow up tasks for our side:
|
Should I separate these into separate issues so we can work piecemeal on it, or are these all just necessary for removing the flag? |
these are all required for removing the flag - lets leave them here. Chris from Lit has to make changes on his end, which prompted these changes here -- there are some small issues with the signature collection on their end, but we worked out a way to make the flow much easier for our users and their users. We just have to wait on his updates now, i addressed a most of these after our call already |
I moved to "ready for dev" so you can start working on the follow up tasks at your leisure, no rush though. |
Lit responded Friday, going to finish this up. |
looked at finishing this up after recieving some communication back from chris at lit, seems like there are still some issues to be worked out here on lits side - sent a message back to chris on the matter |
can the follow-up tasks be tackled or are we fully blocked? |
blocked until chris gets back, some things we discussed the other week still have not been addressed, they ar emaking progress, but its still a blocker for us |
@brossetti1 any more word from Lit? I'd be happy to try to close this out so you can focus on V3 if that is possible. |
#1774 was developed for Lit integration, but they didn't have some API to support it. We merged the code but put it in a feature flag that can be removed once everything is good and working.
relavent pr and comment - #1897 (comment)
The text was updated successfully, but these errors were encountered: