Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI shows wrong percentage of votes if voting power has changed #292

Open
1 of 4 tasks
shayanb opened this issue Apr 10, 2023 · 1 comment
Open
1 of 4 tasks

UI shows wrong percentage of votes if voting power has changed #292

shayanb opened this issue Apr 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@shayanb
Copy link

shayanb commented Apr 10, 2023

Feature

DAOHaus admin, proposals

App

Expected Behavior

Expected behavior is to show the correct voted percentage on historical proposals

Actual Behavior

The voting percentage uses the current voting power and not the voting token distribution at the time of the vote.

Steps to Reproduce

  1. DAO with 2 members (Threshold 20%)
  2. Submit a proposal and vote (50% or 100% Yes)
  3. Change the voting token distribution, by adding more voting members
  4. the previous passed proposals show lower number than the threshold for passed proposals

Browser

No response

Screenshots and Context

Screenshot 2023-04-10 at 2 22 01 PM

@shayanb shayanb added the bug Something isn't working label Apr 10, 2023
@skuhlmann skuhlmann assigned skuhlmann and unassigned skuhlmann May 3, 2023
@skuhlmann
Copy link
Contributor

Adding some working notes here. We've added a subgraph field to give us the block number at execution:
https://github.com/HausDAO/monorepo/tree/fix/292-quorum-snapshot

we'll need to make a new hook to query the proposal at this block number in the component that calculates the vote percentage after the proposal was executed to get the total shares at that snapshot. We'll use that value after execution, before execution we just use the current dao total shares.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants