Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the dependency on DH Connect in the TXBuilder Library #518

Open
1 of 7 tasks
skuhlmann opened this issue Aug 11, 2024 · 1 comment
Open
1 of 7 tasks

Update the dependency on DH Connect in the TXBuilder Library #518

skuhlmann opened this issue Aug 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@skuhlmann
Copy link
Contributor

App

Feature Type

  • New Feature
  • Enhancement

Feature

The TxBuilder library currently takes a viem provider/public client as a prop. This provider is currently only able to be the provider used in DH connect. We want to be able to use any wagmi/viem provider.

Needs to be evaluated more, but might just be a type issue
https://github.com/HausDAO/monorepo/blob/develop/libs/tx-builder/src/TXBuilder.tsx#L3C10-L3C22

  • What other client types are there and can we update to accept those?

Deliverables

  1. Update TxBuilder package so it can use any provider from wagmi/viem and be used in an app that doesn't have DH connect.
  • test with wallet connect/web3modal, rainbow kit, connectkit
  1. Ensure this is backward compatible with DH connect and still works in the summon and admin apps
  • transaction still process?
  1. Create a branch on this repo with an example of another wallet connection implementation
    https://github.com/HausDAO/dao-app-starter-vite
  • wallet connect/web3modal, rainbow kit or connectkit
  1. Submit a PR for testing and we'll work together on a deployment and new release.

Resources

library code
https://github.com/HausDAO/monorepo/tree/develop/libs/tx-builder

provider prop
https://github.com/HausDAO/monorepo/blob/develop/libs/tx-builder/src/TXBuilder.tsx#L83

starter repo to fork and try with other wallet implementations
https://github.com/HausDAO/dao-app-starter-vite
https://github.com/HausDAO/dao-app-starter-vite/blob/main/src/components/layout/DaoContainer.tsx#L94

Screenshots and Context

No response

@skuhlmann skuhlmann added the enhancement New feature or request label Aug 11, 2024
@skuhlmann
Copy link
Contributor Author

The provider type comes from view. So likely not the issue.

Here's an attempt that runs into many more dependency problems.

https://github.com/HausDAO/dao-app-starter-vite/tree/sk/tries-connectkit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant