Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need help, match hero animation across multiple preseting viewcontollers #766

Open
davidfuzju opened this issue Oct 15, 2023 · 1 comment

Comments

@davidfuzju
Copy link

davidfuzju commented Oct 15, 2023

What did you do?

My trasition animation process like this:

  1. B viewcontroller is in a navigation controller, then presenting I viewcontroller which enable hero and
    b.hero.id == i.hero.id, I viewcontroller's modalPresentationStyle is .overCurrentContext
  2. after presening, the navigation controller will push a viewcontroller C with subview c, and b.hero.id == i.hero.id == c.hero.id
  3. then dismiss I viewcontroller

image

What did you expect to happen?

  1. when presenting I view controller, b and i will perform match animation
  2. after push C view controller, I view controller is presenting over C view controller's content
  3. when dismiss I view controller, i and c will perform match animation

What happened instead?

  1. as expected
  2. as expected
  3. not as expected, C view controller will show subview c, and i and c will perform dismiss transition animation,hero won't remove c from view in animation initial state

General Information

  • Hero Version:

1.6.2

  • iOS Version(s):

16.6.1

  • Swift Version:

Swift 5

  • Devices/Simulators:

iPhone 13 Pro Max

  • Reproducible in Examples? (Yes/No):

Demo Project

@davidfuzju
Copy link
Author

davidfuzju commented Oct 15, 2023

animation like this, is there any method to make subview c in C view controller prepare for hero dismiss transition animation from subview b in B view controller?
https://github.com/HeroTransitions/Hero/assets/3890843/df0f8d02-1ac4-4885-b205-680c21345e25

@davidfuzju davidfuzju changed the title need help, match hero animation when presetingviewcontoller changed need help, match hero animation across multiple preseting viewcontollers Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant