Hero 1.6.x Xcode 16 Carthage

[daywalkel2]

Hero SDK not compiling with Carthage in Xcode 16 or 16.1 beta.

/Users/xx/xx/xx/xx/Carthage/Checkouts/Hero/Hero.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 10.0, but the range of supported deployment target versions is 12.0 to 18.1.99. (in target 'Hero (iOS)' from project 'Hero')
note: Disabling previews because SWIFT_VERSION is set and SWIFT_OPTIMIZATION_LEVEL=-O, expected -Onone (in target 'Hero (iOS)' from project 'Hero')
** ARCHIVE FAILED **

The following build commands failed:
CompileSwift normal arm64 (in target 'Hero (iOS)' from project 'Hero')

[daywalkel2]

Here is the line that prevent build in Xcode 16.

// capture a snapshot without alpha, cornerRadius, or shadows
let oldMaskedCorners: CACornerMask = {
if #available(iOS 11, tvOS 11, *) {
return view.layer.maskedCorners
} else {
return []
}
}()

[JoeMatt]

I'm very busy with another project at the moment, could you make a pull request for this?

[daywalkel2]

Hi, i couldnt't create a PR cause it gives me permission denied error. But i can send u the patch diff.

…

On Thu, Oct 10, 2024 at 9:30 PM Joe Mattiello ***@***.***> wrote: I'm very busy with another project at the moment, could you make a pull request for this? — Reply to this email directly, view it on GitHub <#776 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANFZDHB4YDPENHOABIN6VZTZ23BVXAVCNFSM6AAAAABOPL4RCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBVG44DENJYGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>