Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove override specification #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove override specification #23

wants to merge 1 commit into from

Conversation

irwincong
Copy link

@irwincong irwincong commented Aug 13, 2021 •
edited
Loading

IncludesProcessor::InclusionDirective was declared with an override specification. IncludesProcessor inherits from PPCallbacks, and it does not declare an InclusionDirective virtual function (in LLVM 6.0.1).

This change makes it so that the preprocessor tool actually compiles.

Closes #14; Closes #19

@irwincong
Remove override specification
93c0d72 
IncludesProcessor::InclusionDirective was declared with an override specification. IncludesProcessor inherits from PPCallbacks, and it does not declare an InclusionDirective virtual function.
@Marsman1996
Copy link
Contributor

Marsman1996 commented Aug 18, 2021 •
edited
Loading

I'm still wondering whether they use LLVM 7 or LLVM 6, since the declaration in

FuzzGen/src/preprocessor/preprocessor.h

Lines 210 to 212 in 3441115

virtual void InclusionDirective(SourceLocation, const Token &, StringRef, bool, CharSourceRange,
const FileEntry *, StringRef, StringRef, const clang::Module *,
SrcMgr::CharacteristicKind) override;
matches with
https://github.com/llvm/llvm-project/blob/release/7.x/clang/include/clang/Lex/PPCallbacks.h#L124-L134

  virtual void InclusionDirective(SourceLocation HashLoc,
                                  const Token &IncludeTok,
                                  StringRef FileName,
                                  bool IsAngled,
                                  CharSourceRange FilenameRange,
                                  const FileEntry *File,
                                  StringRef SearchPath,
                                  StringRef RelativePath,
                                  const Module *Imported,
                                  SrcMgr::CharacteristicKind FileType) {
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@irwincong @Marsman1996