Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/channel data typing #442

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Fix/channel data typing #442

merged 2 commits into from
Dec 11, 2024
+29 −33

Conversation

marrouchi
Copy link
Contributor

@marrouchi marrouchi commented Dec 10, 2024 •
edited
Loading

Motivation

The following fixes an issue with TS about ChannelData typing. A first attempt (#433) failed to satisfy the typing requirements per channel.

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@marrouchi marrouchi merged commit 3a558df into main Dec 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdou6666 abdou6666 abdou6666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marrouchi @abdou6666