You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Similar patterns appear across the code, and are sometimes treated in different ways, which lacks consistency. This issue aims at identifying them and deciding on the way to treat each of them:
A function needs to do something only if a condition is met. Do we put the condition outside the function (if (m_multi_plasma.IonizationOn() && m_do_tiling) m_multi_plasma.TileSort(bx, geom[lev]);) or in the function (see Fields::AddRhoIons)?
A module can be ON or OFF. How do we test it? m_multi_plasma.IonizationOn() or do_MR or InSameTransverseCommunicator or m_multi_laser.m_use_laser?
This list is in construction. If we agree this is worth improving and decide on a convention, we would put this in the doc and slowly implement it in the code, when we stumble upon it. inconsistencies in naming conventions in the input file should be included too.
The text was updated successfully, but these errors were encountered:
Similar patterns appear across the code, and are sometimes treated in different ways, which lacks consistency. This issue aims at identifying them and deciding on the way to treat each of them:
if (m_multi_plasma.IonizationOn() && m_do_tiling) m_multi_plasma.TileSort(bx, geom[lev]);
) or in the function (seeFields::AddRhoIons
)?m_multi_plasma.IonizationOn()
ordo_MR
orInSameTransverseCommunicator
orm_multi_laser.m_use_laser
?This list is in construction. If we agree this is worth improving and decide on a convention, we would put this in the doc and slowly implement it in the code, when we stumble upon it. inconsistencies in naming conventions in the input file should be included too.
The text was updated successfully, but these errors were encountered: