Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛APP_DISABLE_REGISTRATION and APP_SAAS_MODE_ENABLED do not appear to take effect when running on render.com #287

Open
proffalken opened this issue Nov 13, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@proffalken
Copy link

Note

Please stick to the template and provide as much detail as possible to help us diagnose and fix the issue.
Low effort bug reports will be closed.

Describe the bug
I'm evaluating Hi.Events as a replacement for Alf.io.

I have used the "quick launch" for render.com to deploy, and it appears to be working fine apart from being unable to disable registration.

To Reproduce
Steps to reproduce the behavior:

  1. Deploy via Render.com
  2. Perform the initial setup and registration of the first user account/organisation
  3. Update the environment variables, setting APP_DISABLE_REGISTRATION=true and APP_SAAS_MODE_ENABLED=false
  4. Visit the site in a browser and observe that the Don't have an account? Sign up link is still active.

Expected behavior
The registration link should be removed because SASS mode and Registration have been disabled.

Screenshots
image

image

Logs
N/A

Desktop (please complete the following information):

  • OS: pop!_OS
  • Browser: Brave
  • Version: 1.71.123

Hi.Events Version and platform

Docker latest based on the Render.com auto-deploy

Additional context
This is the second time I've spun up Hi.Events, but the first time I've tried to disable this, so if I'm missing an obvious setting then I apologise!

@proffalken proffalken added the bug Something isn't working label Nov 13, 2024
@daveearley
Copy link
Contributor

Hi @proffalken,

Thanks for the report!

Can you confirm if it's possible to register an account when APP_DISABLE_REGISTRATION is enabled? Currently, the "Don't have an account? Sign up" link isn't hidden when registration is disabled; this setting only affects the API, not the frontend. It definitely should apply to the frontend as well, so that part is indeed a bug.

Thanks again!

@proffalken
Copy link
Author

Ah, thanks @daveearley - I'd not tried to register, I'd just assumed I'd see the UX link disappear.

I can confirm that I get an "account registration is disabled" notification when trying to setup a new account, so it appears to be front-end only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants