From a81748430311e932be7df5b230e0ea68d9d12bc1 Mon Sep 17 00:00:00 2001
From: James Friel <jfriel001@dundee.ac.uk>
Date: Mon, 25 Sep 2023 15:26:09 +0100
Subject: [PATCH] tidy up the code a bit

---
 DrsPlugin/Attachers/DrsFileAttacher.cs     | 1 -
 DrsPlugin/Extraction/DRSImageExtraction.cs | 6 +++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/DrsPlugin/Attachers/DrsFileAttacher.cs b/DrsPlugin/Attachers/DrsFileAttacher.cs
index e814298..aa89637 100644
--- a/DrsPlugin/Attachers/DrsFileAttacher.cs
+++ b/DrsPlugin/Attachers/DrsFileAttacher.cs
@@ -181,7 +181,6 @@ private void UpdateRAWWithImageArchiveLocations(IDataLoadJob job, Dictionary<str
             if (!entry.Any())
                 throw new InvalidOperationException($"There are no file mappings for archive: {archive}");
 
-            //here?
             var query =
                 $"UPDATE [{TableName}] SET {ImageArchiveUriColumnName} = CONCAT('{archive}!', {FilenameColumnName}) WHERE {FilenameColumnName} IN ('{string.Join("','", entry)}')";
 
diff --git a/DrsPlugin/Extraction/DRSImageExtraction.cs b/DrsPlugin/Extraction/DRSImageExtraction.cs
index e11ece8..181ac2b 100644
--- a/DrsPlugin/Extraction/DRSImageExtraction.cs
+++ b/DrsPlugin/Extraction/DRSImageExtraction.cs
@@ -56,7 +56,6 @@ public override DataTable ProcessPipelineData(DataTable toProcess, IDataLoadEven
 
             if (string.IsNullOrWhiteSpace(row[ImageUriColumnName].ToString()))
             {
-                //here is a skip
                 listener.OnNotify(this, new NotifyEventArgs(ProgressEventType.Warning,
                     $"Row {progress} does not have a corresponding image, [{ImageUriColumnName}] is empty."));
                 continue;
@@ -83,9 +82,10 @@ public override DataTable ProcessPipelineData(DataTable toProcess, IDataLoadEven
                 {
                     File.Copy(Path.Combine(PathToImageArchive, sourceFileName), newFilename);
                 }
-                catch (Exception e)
+                catch (Exception e) //todo this should handle the exceptions better
                 {
-
+                    listener.OnNotify(this, new NotifyEventArgs(ProgressEventType.Information,
+                               $"Failed to copy file (${sourceFileName})."));
                 }
 
                 continue;