Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup unit tests. #99

Open
1 task
a-t-0 opened this issue Jan 24, 2022 · 0 comments
Open
1 task

Setup unit tests. #99

a-t-0 opened this issue Jan 24, 2022 · 0 comments

Comments

@a-t-0
Copy link
Contributor

a-t-0 commented Jan 24, 2022

  • Convert the installation scripts into tested functions that are executed according to some order.
    Ideally, first setup the self-hosted GitLab CI in this repo: https://github.com/Simple-Setup/Self-host-GitLab-Server-and-Runner-CI then make that Style Guide Compliant, and after that start converting the files/scripts in this repository into unit-tested functions.

The preference for first fixing the GitLab CI in that repo, is such that pull requests on this repo then will get automatic CI, which is a convenient way of working.
The preference for first making that repo Google Style Guide compliant is subjective, I think it is wise to take a step back in creating new functionalities, and to clean up the repositories, right now. I believe this allows a higher rate of creating new functionalities in the long run, improves code quality, and makes it easier for others to contribute to this repository. Another important factor is that it is a step towards applying the TruCol protocol to this repository, (which requires a high test coverage and proper test setup).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant