Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering previously registered holoport creates stale entries in ZT Central #47

Open
peeech opened this issue Jan 4, 2022 · 2 comments

Comments

@peeech
Copy link
Contributor

peeech commented Jan 4, 2022

Whenever user is registering holoport with holochain_agent_id that has already been registered a new entry is created in ZT Central registry.

ZT Central is using address field as a unique key, but many services downstream use name field (which is populated with holochain_agent_id) as a unique key. Because process mentioned above creates multiple entries with the same name value the structure of database from the perspective of downstream services is corrupted.

So in the name of brotherhood with downstream consumers I am suggesting deleting all the old entries where name == holochain_agent_id while creating a new entry.

This would require making 1 more call after this line of a server code.

@alastairong
Copy link
Contributor

This is more complex as we want to make sure we don't lose any data from their past life e.g. uptime history.

So in theory yes, in practice let's think through this carefully.

@alastairong
Copy link
Contributor

Have checked matching-engine code and this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants