Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casks with appcast and :no_check #54811

Closed
48 of 53 tasks
vitorgalvao opened this issue Nov 12, 2018 · 36 comments
Closed
48 of 53 tasks

Casks with appcast and :no_check #54811

vitorgalvao opened this issue Nov 12, 2018 · 36 comments
Labels
good first issue Issue which is easy to tackle for first-time contributors.

Comments

@vitorgalvao
Copy link
Contributor

vitorgalvao commented Nov 12, 2018

Followup to #54715.

These casks have an appcast but are using :no_check. They should be updated to have a proper version and sha256, even if the url is unversioned.

If you update some based on this issue, please comment below with a link to your PR, so we can update the list.

@vitorgalvao vitorgalvao added the good first issue Issue which is easy to tackle for first-time contributors. label Nov 12, 2018
@ran-dall
Copy link
Contributor

#54837 - amazon-workdocs
#54838 - amazon-workspaces
#54839 - anylist
#54841 - between
#54842 - bill
#54843 - bluesense

@vitorgalvao Did the As and Bs. It's fairly simple using your cask-repairtool and Pacifist. If these look right, I can finish them off for you.

@vitorgalvao
Copy link
Contributor Author

@ran-dall Yes, the way you’re doing it helps. Even if I need to edit them, having the correct version and sha256 already saves a bunch of time. You can carry on. Thank you!

Out of curiosity, how did you find this issue?

@ran-dall
Copy link
Contributor

@vitorgalvao Thanks! I'll finish it up.

I found the issue just by looking at the issues board. Saw something I could help with and decided to do it. I updated the Eclipse-JavaScript cask, so I figured what the hell...

I dare say that Cask-Repair makes it interesting, even a bit fun...I know I'm an odd animal.

@vitorgalvao
Copy link
Contributor Author

I found the issue just by looking at the issues board. Saw something I could help with and decided to do it.

Did the good first issue label help in making your decision to check the issue? I ask because I added it and also tweeted about the issue, so I’m curious if any of those things made a difference.

I dare say that Cask-Repair makes it interesting, even a bit fun

Thank you. I’ve seen other people express similar sentiments in the past. That makes me glad to know!

@ran-dall
Copy link
Contributor

ran-dall commented Nov 13, 2018

@vitorgalvao I did find it curious. I don't know if it made a huge difference, but it did make me want to read into it.

My cask-repair went haywire this morning. I'm back at it now. However, in the process, I guess I updated 'cloudmounter'? I don't know if you could check it, but it seemed like it's updated somewhere along the process.

I don't know what really happened really happened with cask-repair. I'm thinking maybe my SSH-Key into GitHub Hub must have dislocated itself. It kind of fixed itself after I followed this guide, and I read over some of the issues (specifically vitorgalvao/tiny-scripts#87 was super helpful) in your tiny-scripts repo. Basically, I reset everything and it started working again.

Specifically, it was giving this error:
origin is pointing to an incorrect remote (https://github.com/Homebrew/brew.git). Its beginning must match (https://|git@)github.com[/:]Homebrew/homebrew-cask.
...so I fixed it after cleaning everything and ran:
git remote set-url origin https://github.com/Homebrew/homebrew-cask

So, I'm back at it now...

@chrisfinazzo Thanks for picking up those up.

@ran-dall
Copy link
Contributor

ran-dall commented Nov 13, 2018

@vitorgalvao NM. It was still messed up. I fixed it. Lol.

Here everything to the Gs.

Here's the new ones:
#54908 - cloudmounter
#54909 - dashlane
#54910 - dyn-updater
#54911 - easycorp
#54912 - elmedia-player
#54913 - eudic
#54914 - flirc
#54915 - gotiengviet

@ran-dall
Copy link
Contributor

ran-dall commented Nov 13, 2018

@vitorgalvao Here's more...
#54916 - haptic-touch-bar
#54917 - hubstaff
#54918 - ibackup-viewer
#54919 - iholdem-indicator
#54921 - ilok-license-manager (might have made an error in the GM)
#54920 - ios-console
#54922 - ishowu-instant
#54923 - ishowu-studio
#54924 jumpshare (Check this one. The installation is different. As the original URL didn't work anymore.)
#54925 - lingo
#54926 - live-interior-3d-pro
#54927 - livechat
#54928 - macpilot
#54929 merlin-project
#54930 - mollyguard
#54931 - origami-studio

@ran-dall
Copy link
Contributor

ran-dall commented Nov 13, 2018

@vitorgalvao These got close on accident, Timings was giving me issues and it true the git out of sync. I tried to do the re-do the process and it broke. I've restored branches and the pull requests.

#54926 - live-interior-3d-pro
#54927 - livechat
#54928 - macpilot
#54929 merlin-project
#54930 - mollyguard
#54931 - origami-studio
#54933 - picka
#54934 - product-hunt
#54935 - rest
#54936 - sandvox
No longer valid - scenery
#54937 - securedownloadmanager
#54938 - the-clock

@ran-dall
Copy link
Contributor

@vitorgalvao Here's the rest. Let me know if you want me to redo the ones that I messed up...

#54940 - timing
#54939 - tiny
#54942 - touchswitcher
#54941 - triumph
#54943 - tuneskit-m4v-converter
#54944 - twindocs
#54945 - upthere-home
#54946 - watts
#54947 - zenmate-vpn

@ran-dall
Copy link
Contributor

ran-dall commented Nov 15, 2018

@vitorgalvao triumph was merged (#54941), and Twindocs is still open (#54944). Scenery no longer exists. That should close this.

@vitorgalvao
Copy link
Contributor Author

@ran-dall Thank you for the good work!

@core-code
Copy link
Contributor

thanks, i think its awesome how @ran-dall stepped in here.

another thing where the community could help and which would be a great "good first issue" in my opinion is our work we have been doing on pr #52837

basically we are automatically identifying casks that are very likely to be outdated and which should be cask-repaired. the idea here was to automate that too, but that hasn't played out yet, and since there are always around 20% false positives, i'm not sure how to do that (unless you blindly submit anything thats on the server - which is a bad idea).

each day the new file is stored here:
http://macupdater.net/cask-repair/
most interesting is basically the 'processed' file, i.e. the newest one ATM is:
http://macupdater.net/cask-repair/cr-processed-2018-11-17.txt

me and mostly @suschizu have been going over this list each day but it would be awesome if the community could step in here as we won't have much time for that for some time.

basically whats needed is to go over the list and for each app:
• have a look if the proposed new version actually exists (i.e. on their homapage), and if it does, do a cask-repair
• if it doesn't exist (=>false positive) let me know so i can put it on the ignore list (there are 3 different ones as explained in the thread) so it won't show up again. basically i have to update the postprocessing script ( http://macupdater.net/cask-repair/postprocessCaskRepairOutput.py.txt )

so, @vitorgalvao it would be awesome if you could create another 'issue' like that with the 'good first issue' label with the info i've written above. if you don't think its a good idea, or e.g. want me to create the issue just let me know.

@ran-dall
Copy link
Contributor

@core-code Thanks for your recognition. Couldn't have been done without the help of the great @vitorgalvao.

I'd be happy to keep track of these files and keep them up to date. I've already been helping people out with the stuff that @vitorgalvao has been schooling me on. I think I've come a long way. It's amazing how many people don't read the /docsor the PR / Issue template. Anyways, I'll get the outdated Casks from today updated shortly.

I'm usually glued to my computer 34/7/365 (for a variety of professional, business, and enthusiast reasons, much to my wife's dismay), so this should be something I can generally be depended on to take care of for you. If for whatever reason I'll be gone (and without a computer), I'll let you guys know.

Besides, I enjoy homebrew-cask; and cask-repairis pretty awesome too (much credit and respect to @vitorgalvao ).

I've also read through #52837. It gave me a lot of insight. Thanks for sharing. I found @brianmorton automation script a few days ago and was playing around with it. I didn't realise the whole picture as much as I do know. I have a few ideas I've been playing around the last few days that I might add to the thread (#52837) if they prove to reliable.

Side-note: The raw data output you're doing is excellent stuff. Good work!

@ran-dall
Copy link
Contributor

ran-dall commented Nov 17, 2018

@core-code gog-galaxy, goland, wacom-tablet, and wondershare-video-converter-ultimate need closer looks. I need to run.

Otherwise, everything else should be updated.

@vitorgalvao
Copy link
Contributor Author

or e.g. want me to create the issue just let me know.

Please do. The system is your creation so you’ll be explain it better. I’ll add the tag.

@core-code
Copy link
Contributor

@ran-dall awesome, thanks!

gog-galaxy: think its a false positive, i've made sure this version is ignored. if this happens more often, we'll need to take more drastic action here
wacom-tablet: i already did a PR here to update it (it lives in the homebrew-cask-drivers repository, as the '=' prefix indicates). this may already have gone through by the time you looked at it. my system currently can't filter things where there is already a pull-request open
wondershare-video-converter-ultimate: this was a valid update and i've submitted a PR. the wondershare guys update their files in-place most of the time
goland: sorry will have to take a look at this later on

new output for today is up.

p.s. i also feel like i am glued to the computer 34 hours per day ;)

@core-code
Copy link
Contributor

Please do. The system is your creation so you’ll be explain it better. I’ll add the tag.

thanks, i'll do so later on

@ran-dall
Copy link
Contributor

ran-dall commented Nov 18, 2018

@core-code NP. I was just getting my homework started. Now, my homework is done for the day, sir!

Notes for the day:
cmake 3.13.0 - is a release candidate but almost ready for release
datasciencestudio - already has an open pull request for version 5.0.3 by @suschizu (#55047)
gray - I fat fingered the e key and accidentally deleted the pull request (#55115), which I replaced and updated to handle Mojave and anything else below.
intellij-idea and goland - pretty sure it's a false positive because on their website they have the same version as HBC, but those versions do exist I think maybe it's pre-release or something of the sort. I download and checked the Info.plists with 'PlistEdit Pro', even the patch numbers are the same.

Everything else is updated.

Side Note: Maybe we should move this to the new issue?

@core-code
Copy link
Contributor

core-code commented Nov 20, 2018

sorry, off on an (even more ;) remote island and finding little time for proper things ATM. i try to run the script daily though so there should be up-to-date output on the server each day.

i've made sure the cmake release candidate is ignored now.

intellij-idea and goland .. .quite sure those vendors distribute beta versions so it might be better to just ignore those. will need to look if they have other ways to keep them updated them though.

@ran-dall
Copy link
Contributor

@core-code I was wondering what happened to you! I totally understand. I was looking for the output this morning and didn't see it. Anyways, jobs done...

double-commander - False positive (https://sourceforge.net/p/doublecmd/wiki/Download/)
data-dog - STILL OPEN (#54739)
knockknock - BETA (https://bitbucket.org/objective-see/deploy/downloads/)
progressive-downloader - False positive (https://www.macpsd.net)

@ran-dall
Copy link
Contributor

@core-code Are false positives apps that auto-update maybe?

@core-code
Copy link
Contributor

thanks. i've updated the false positive list and uploaded new output.

i don't think there is a connection between "auto-updates" and 'false positive'.

'false positive' here just means that one of our users is using a version of an app that is not an official release - e.g. beta or test versions. there is probably no connection between whether an app can automatically update and whether an app distributes beta versions.

@ran-dall
Copy link
Contributor

@core-code Nice! I'll get to it shortly. I'll let you know when I'm done.

I was just critically thinking, and the users are getting these updates somewhere. I was investigating with JetBrains (as I was given a free Lifetime license for winning an AI hackathon a few months ago) and it seems that these versions are installed via JetBrains Toolbox. So it kinda acts like that of an auto-update as JetBrains seems to be pushing out updates almost every week thru JetBrains Toolbox. Which got me to thinking, these apps basically update on their own if you have the apps managed via JetBrains Toolbox; which was the basis of my comment.

@ran-dall
Copy link
Contributor

ran-dall commented Nov 21, 2018

@core-code Here's the work...

datadog-agent - STILL OPEN (#54739 )
alfred - false positive (https://www.alfredapp.com/)
texstudio - pre-release (https://github.com/texstudio-org/texstudio/releases/) (also conflicts_with cask: 'texstudio-beta')

Everything else is updated.

@brianbrownton
Copy link
Contributor

@ran-dall that's for stepping in with such enthusiasm. If you need any help with my scripts, let me know here or open an issue on the repo: https://github.com/brianmorton/cask-automation

@core-code
Copy link
Contributor

core-code commented Nov 21, 2018

Please do. The system is your creation so you’ll be explain it better. I’ll add the tag.

@vitorgalvao i've done so here: #55268

@ran-dall
Copy link
Contributor

@core-code Good work on #55268 ! 👍

@ran-dall
Copy link
Contributor

@brianmorton I really appreciate that! I will keep you in the loop. Thanks for all your great work too!

@core-code
Copy link
Contributor

@core-code Good work on #55268 ! 👍

thanks, good job on the cask-repairs ;)

@ran-dall
Copy link
Contributor

ran-dall commented Nov 21, 2018

@core-code Couldn't be done with your output. 😁

One small request though, if you could leave me a mention when you put up new outputs. That would be helpful.

EDIT: I'm working on today's casks. I'll message you there from now on...

@core-code
Copy link
Contributor

i'll try to leave a note in #55268 from now on

@ran-dall
Copy link
Contributor

@core-code Thank You!

@core-code
Copy link
Contributor

i think the intellij (idea, pycharm, goland) updates that were previously false-positive are out in final now

@vitorgalvao
Copy link
Contributor Author

i think the intellij (idea, pycharm, goland) updates that were previously false-positive are out in final now

Those casks already have a bot (see #55252 for an example), so you may want to speak to the bot’s author.

@core-code
Copy link
Contributor

ah thanks good to know that bot exists
@leipert many thanks for jcbot. i'll be excluding these casks from my system as they are already handled perfectly.

@leipert
Copy link
Contributor

leipert commented Nov 24, 2018

@core-code Thanks for the kind words 😄

@lock lock bot locked and limited conversation to collaborators Dec 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Issue which is easy to tackle for first-time contributors.
Projects
None yet
Development

No branches or pull requests

5 participants