Double images appearing after upgrading to 1.17?

[KrisHedges]

The current system I've built has images (png) embedded for "sign here" where signatures go...
When applying the signatures I remove those "sign here" images and drawImage the new embedded signature image.

Prior to 1.17 this all worked fine and downgrading 1.16 fixes the issue

What I'm seeing appears to be some sort of off by one error in the embedder stack or something.
If I have multiple signature fields,the first occurrence what I see happening is the old ref & name
for the "sign here" image is still on the page and uses the new embedded signature image. So it appears
like 2 signature images stacked. My new drawn version is there where I expect it fine. The second or
any subsequent occurrence will be fine meaning the "sign here" is completely removed as expected
and just the newly drawn signature image will be there. So it's like the doc context no longer has the ref
but the page still does and falls to nearest or something... it's very bizarre behaviour.
Downgrading to 1.16 fixes the issue and debugging is very difficult..

Examples of the functions below any feedback appreciated...

Script that embeds the sign here images

async function processFormSignatures(pdfBuffer, template_data) {
    const pdfDoc = await PDFDocument.load(pdfBuffer);
    const embeddedFont = await pdfDoc.embedFont(StandardFonts.Helvetica);
    const form = pdfDoc.context.lookup( pdfDoc.catalog.get( PDFName.of( 'AcroForm' )));

    const signFilePath = path.join(__dirname, '..', 'utilities', 'assets', 'signhere.png');
    const signHereBytes = fs.readFileSync(signFilePath);
    const signhere = await pdfDoc.embedPng(signHereBytes);

    if ( !form ) {
        throw new Error( 'PDF does not contain a form' );
    }

    const fieldRefs = form.context.lookup( form.get( PDFName.of( 'Fields' )));

    if ( !fieldRefs ) {
        throw new Error( 'PDF form does not contain any fields' );
    }

    const fields = fieldRefs.array.map( (ref) => form.context.lookup(ref));
    let sigFieldCount = 0;
    fields.forEach( field => {
        const fieldtype = field.get( PDFName.of( 'FT' ));
        if (fieldtype.encodedName == '/Sig'){
            sigFieldCount++;
            const fieldRect = field.get( PDFName.of( 'Rect' ));
            const x = fieldRect.array[0].numberValue;
            const y = fieldRect.array[1].numberValue;

            // Get the current page
            const page_number = field.get(PDFName.of( 'P' )).objectNumber;
            const page_objectnumbers = pdfDoc.getPages().map( function(page){
                return page.ref.objectNumber;
            });

            // Gather info about our page
            let page_index = page_objectnumbers.indexOf(page_number);
            let current_page = pdfDoc.getPages()[page_index];

            current_page.drawImage(signhere, {
                x: x,
                y: y + 7,
                width: 77,
                height: 19
            });
        }
    });
    pdfDoc.setTitle(template_data.document_name);
    const doc = await pdfDoc.save({updateFieldAppearances: false});
    return {
        'doc': doc,
        'signature_count': sigFieldCount
    };
}

Script that later removes the sign here images and adds the signature images

async function applySignaturesToForm(pdfBuffer, signature_image, request_data) {
    const pdfDoc = await PDFDocument.load(pdfBuffer);
    const embeddedFont = await pdfDoc.embedFont(StandardFonts.Helvetica);
    const form = pdfDoc.context.lookup( pdfDoc.catalog.get( PDFName.of( 'AcroForm' )));
    const signature = await pdfDoc.embedPng(signature_image);

    if ( !form ) {
        throw new Error( 'PDF does not contain a form' );
    }

    const fieldRefs = form.context.lookup( form.get( PDFName.of( 'Fields' )));

    if ( !fieldRefs ) {
        throw new Error( 'PDF form does not contain any fields' );
    }

    const fields = fieldRefs.array.map( (ref) => {
        return { field: form.context.lookup(ref), ref: ref };
    });

    fields.forEach( objpair => {
        const fieldtype = objpair.field.get( PDFName.of( 'FT' ));
        const fieldname = objpair.field.get( PDFName.of( 'T' ));
        const date = new Date();

        if (fieldtype.encodedName == '/Tx' && fieldname.value.includes('customer_signature')){
            if( fieldname.value.includes('customer_signature_date') ){
                var dateString = (date.getMonth() + 1) + "-" + date.getDate() + "-" + date.getFullYear();
                Draw.text(objpair.field, fieldname.value, dateString, embeddedFont, pdfDoc);
            }
            if( fieldname.value.includes('customer_signature_name') ){
                let signator_name = request_data['firstName'] + " " + request_data['lastName'];
                Draw.text(objpair.field, fieldname.value, signator_name, embeddedFont, pdfDoc);
            }
        }

        if (fieldtype.encodedName == '/Sig'){
            const fieldRect = objpair.field.get( PDFName.of( 'Rect' ));
            const left = fieldRect.array[0].numberValue;
            const bottom = fieldRect.array[1].numberValue;
            const right = fieldRect.array[2].numberValue;
            const top = fieldRect.array[3].numberValue;

            // Gather info about our page
            // Get the current page
            const page_for_field = objpair.field.get(PDFName.of( 'P' ));
            const page_number = page_for_field ? page_for_field.objectNumber : 1;
            const page_objectnumbers = pdfDoc.getPages().map( function(page){
                return page.ref.objectNumber;
            });

            let page_index = page_objectnumbers.length > 1 ? page_objectnumbers.indexOf(page_number) : 0;
            let current_page = pdfDoc.getPages()[page_index];

            objpair.field.set( PDFName.of( 'T' ), PDFString.of( 'Text' ));
            objpair.field.set( PDFName.of( 'Type' ), PDFString.of( 'Text' ));
            objpair.field.set( PDFName.of( 'V' ), PDFHexString.fromText('')); // Using Hex String allows for special chars
            objpair.field.set( PDFName.of( 'DV' ), PDFHexString.fromText('')); // Using Hex String allows for special chars
            objpair.field.set( PDFName.of( 'Ff' ), PDFNumber.of(0));
            objpair.field.delete(PDFName.of( 'DR' ));
            objpair.field.delete(PDFName.of( 'AP' ));

            current_page.drawImage(signature, {
                x: left,
                y: bottom,
                width: 150,
                height: 42
            });

            //Replace/Remove Sig field with empty Object
            pdfDoc.context.delete(objpair.ref);

            // Cleanup "Sign Here" Images
            // We have very little to go on here so we check the width and height
            // and if it matches our 'sign here' image we assume that's what it is and delete it..
            var pages = pdfDoc.getPages();
            let xObjects = current_page.node.Resources().lookup(PDFName.of('XObject'), PDFDict);
            xObjects = Array.from( xObjects.dict );
            xObjects.forEach( xobjpair => {
                if( xobjpair[0]['encodedName'].includes('Image') ){
                    let embedded_image = pdfDoc.context.lookup(xobjpair[1]);
                    if (embedded_image && embedded_image.hasOwnProperty('dict')){
                        let width = embedded_image.dict.get(PDFName.of('Width')).value();
                        let height = embedded_image.dict.get(PDFName.of('Height')).value();
                        if(width == 213 && height == 53){
                            pdfDoc.context.delete(xobjpair[1]);
                        }
                    }
                }
            });
        }
    });
    const title =  "(Signed Copy) " + pdfDoc.getTitle();
    pdfDoc.setTitle(title);
    const doc = await pdfDoc.save({updateFieldAppearances: false});
    return {
        'title': title,
        'doc': doc
    };
}

[rafaelgomesxyz]

I think this is the same as #1075, which should be fixed in v1.17.1.