Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the batch submisson cluster agnostic #191

Open
jcblemai opened this issue Mar 19, 2024 · 5 comments · Fixed by #329 · May be fixed by #394
Open

make the batch submisson cluster agnostic #191

jcblemai opened this issue Mar 19, 2024 · 5 comments · Fixed by #329 · May be fixed by #394
Assignees
Labels
batch Relating to batch processing. high priority High priority.

Comments

@jcblemai
Copy link
Collaborator

There are hardcoded paths and slurm loaded modules, these need to be provided as separate scripts -- that the user can override from its home directory, such that we can run on any slurm cluster

@jcblemai jcblemai added batch Relating to batch processing. low priority Low priority. labels Mar 19, 2024
@shauntruelove shauntruelove added high priority High priority. and removed low priority Low priority. labels Jul 23, 2024
@TimothyWillard
Copy link
Contributor

@shauntruelove I saw you assigned this issue to me and it's labeled as high priority, do we have a desired outcome and deadline for this since this is now high priority? I'm not super familiar with the details of this issue, @jcblemai or @shauntruelove would you be able to fill those in?

@shauntruelove
Copy link
Member

Notes:

  • need agnostic handling of secrets
  • remove hard-coded specifications with Rockfish
  • make work for Longleaf and others
  • add workflow section of the config to tell where everything goes

@TimothyWillard
Copy link
Contributor

TimothyWillard commented Sep 13, 2024

@pearsonca @jcblemai I've attached the branch I'm doing the documentation updates to to this issue.

@jcblemai
Copy link
Collaborator Author

jcblemai commented Sep 13, 2024

[twillard@longleaf-login6 ~]$ sg rc_jlessler_pi -c "touch foobar.txt"
[twillard@longleaf-login6 ~]$ ls -lah foobar.txt
-rw-r--r-- 1 twillard rc_jlessler_pi 0 Sep 13 11:25 foobar.txt

We need to ensure that everyone can access the run, so commands should be optionally run for a configurable certain group of user.
su requires sudo, sg does not (edited)

@TimothyWillard
Copy link
Contributor

TimothyWillard commented Sep 16, 2024

Update as of EOD 2024-09-16:

  • It is now possible to cleanly and consistently install flepiMoP on Longleaf using the build/hpc_install.sh script on the GH-191/longleaf-batch-submission branch. Yet to add rockfish, pending access to be able to work through adding that as a supported cluster.
  • Corresponding documentation changes have been started on the GH-191/longleaf-batch-submission-documentation branch
  • Added support for providing a slurm --partition to the batch/inference_job_launcher.py script, see bba583a.
  • Still yet to successfully submit a batch run on Longleaf. Managed to successfully submit a batch run on Longleaf, yet to verify it worked correctly.

@TimothyWillard TimothyWillard linked a pull request Oct 2, 2024 that will close this issue
TimothyWillard added a commit that referenced this issue Oct 22, 2024
Required resolving conflicts in `inference`'s `DESCRIPTION` and
`install_cli.R`.
TimothyWillard added a commit that referenced this issue Oct 23, 2024
@TimothyWillard TimothyWillard linked a pull request Nov 15, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch Relating to batch processing. high priority High priority.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants