Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: refactor model_info #366

Open
pearsonca opened this issue Oct 28, 2024 · 0 comments
Open

[Feature request]: refactor model_info #366

pearsonca opened this issue Oct 28, 2024 · 0 comments
Assignees
Labels
config Relating to configuration files or their framework. low priority Low priority.

Comments

@pearsonca
Copy link
Contributor

Label

config, meta/workflow

Priority Label

low priority

Is your feature request related to a problem? Please describe.

Part of the too-tightly coupled nature of flepimop internals.

Is your feature request related to a new application, scenario round, pathogen? Please describe.

No response

Describe the solution you'd like

As written, ModelInfo objects know how to write themselves to a specific place. This means that their signature includes lots of arguments that have nothing to do with their core purpose. This also means that their construction arguments are fundamentally entangling with their pickling arguments - that means that if you wanted to, e.g., write whatever ModelInfo's yield to two different places, you'd have to construct two different instances.

I get the instinct here - definitely need some kind of friend pattern. But it makes more sense to have all this file handling / formatting as its own encapsulated capability.

@pearsonca pearsonca self-assigned this Oct 28, 2024
@TimothyWillard TimothyWillard added config Relating to configuration files or their framework. low priority Low priority. labels Oct 28, 2024
@TimothyWillard TimothyWillard added this to the Software Quality milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Relating to configuration files or their framework. low priority Low priority.
Projects
None yet
Development

No branches or pull requests

2 participants