Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: cyclic dependencies between model_info, seeding, and initial_conditions complicate type hinting #397

Open
pearsonca opened this issue Nov 13, 2024 · 2 comments · May be fixed by #422
Labels
dependency For issues with package dependencies. gempyor Concerns the Python core. high priority High priority.

Comments

@pearsonca
Copy link
Contributor

Label

bug, dependency

Priority Label

medium priority

Describe the bug/issue

We cannot easily introduce type hinting for modinf arguments in seeding and initial_conditions given the cyclic dependency.

We desire to not have cyclic dependencies (this enables easier refactoring, e.g.), and so should determine a way to either remove the model_info dependency in seeding / initial_conditions or vice versa.

To Reproduce

No response

Environment, if relevant

No response

@TimothyWillard TimothyWillard added gempyor Concerns the Python core. low priority Low priority. dependency For issues with package dependencies. high priority High priority. and removed low priority Low priority. labels Nov 15, 2024
@TimothyWillard
Copy link
Contributor

I bumped up the priority on this. The more I think about the more I think this cyclic dependencies issue is going to lock up development at some point (in very gnarly fashion) and I'd rather address that before it blocks us. It would be especially inconvenient if that occurred when trying to fix a high priority bug or make a submission.

@pearsonca
Copy link
Contributor Author

makes sense to me. i suspect that cyclic dependencies are more than just a model_info issue, so we should be thinking about how to reveal the others. expanding the type-hinting coverage would probably do the trick, so maybe prioritize that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency For issues with package dependencies. gempyor Concerns the Python core. high priority High priority.
Projects
None yet
2 participants