Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Create A gempyor Inference ABC #402

Open
TimothyWillard opened this issue Nov 18, 2024 · 0 comments
Open

[Feature request]: Create A gempyor Inference ABC #402

TimothyWillard opened this issue Nov 18, 2024 · 0 comments
Labels
enhancement Request for improvement or addition of new feature(s). gempyor Concerns the Python core. inference Concerns the parameter inference framework. medium priority Medium priority.

Comments

@TimothyWillard
Copy link
Contributor

Label

enhancement, gempyor, inference

Priority Label

medium priority

Is your feature request related to a problem? Please describe.

The inference functionality in gempyor is split between the gempyor.calibrate.calibrate function and the gempyor.inference.GempyorInference class. It makes it difficult to understand what each component does and makes it impossible to implement new inference effectively.

Is your feature request related to a new application, scenario round, pathogen? Please describe.

No response

Describe the solution you'd like

An ABC for an inference class that clearly defines what is expected of a modular inference class. Will need to accept information about the model as well as a simulate function (see GH-367) and exposes methods to run inference. Should succeed GH-105 specifically for inference.

@TimothyWillard TimothyWillard added enhancement Request for improvement or addition of new feature(s). gempyor Concerns the Python core. medium priority Medium priority. inference Concerns the parameter inference framework. labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for improvement or addition of new feature(s). gempyor Concerns the Python core. inference Concerns the parameter inference framework. medium priority Medium priority.
Projects
None yet
Development

No branches or pull requests

1 participant