-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch exceptions when there are errors #13
Comments
ghost
self-assigned this
Oct 7, 2014
Can you remember which urlopen was throwing the exception? |
Hi Daniel, No sorry that was quite a while ago. I can also not remember whether it was a wrong url or a url that resulted in a wrong file type. If I get a chance I will try to rerun without the try catch and see whether it errors again or not. |
rachmadaniHaryono
added a commit
to rachmadaniHaryono/RedditImageGrab
that referenced
this issue
Jul 29, 2015
HoverHell
added a commit
that referenced
this issue
Oct 2, 2015
fix issues #13 : add try catch exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While downloading an exception was thrown when
urlopen
was called.I am no Python programmer, but adding a try catch worked in resolving the issue for me. I am sure you can think of a better way than my code, so I didn't make a pull request.
I think it is fine to just not retrieve things where exceptions are raised because in the end we are just mass downloading some thing, so missing 1 for every 10~40 is fine.
Hope this helps.
The text was updated successfully, but these errors were encountered: