Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the repository python 3 compatible. #87

Open
arshjat opened this issue Nov 12, 2018 · 4 comments
Open

Made the repository python 3 compatible. #87

arshjat opened this issue Nov 12, 2018 · 4 comments

Comments

@arshjat
Copy link

arshjat commented Nov 12, 2018

I've made the repository python 3 compatible after doing some major changes in the code.
Major difference between what I did and the jtara1 repository is that I did only basic fixes that span up to only 3-4 line changes in reddit.py, 3-4 changes in redditdownload.py and one line change in gfycat.py and it is working perfectly.

Is there any way for my contribution to be taken?

Hoping for a response.

@Revan654
Copy link

Revan654 commented Nov 12, 2018

Do a Pull request, It's unlikely it will be seen since the Dev hasn't updated the code for years. It will need approval, Have no idea if he's still around or not.

It's just better to Fork the Project and just do updates from there.

@rachmadaniHaryono
Copy link
Contributor

or better use updated fork and recruit people to collaborate

@arshjat
Copy link
Author

arshjat commented Nov 14, 2018

Thank you @Revan654 and @rachmadaniHaryono for the response, I'll continue with my fork.

@Revan654
Copy link

Revan654 commented Nov 16, 2018

Thank you, I'll continue with my fork.

@arshjat

Not sure if you tested the Script yet, One thing I did notice is (Basing it off of Python 3.7.1):

You have: connection = urllib.urlopen

It Should be: urllib.request.urlopen

I will try it shortly. Grad someone picked it up where Orig. Dev left off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants