Cicle wallpaper and theme #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add script to cycle through and set wallpaper and themes for desktop and login screen
The whole file was remade. Original output and use stays the same.
|
Thank you for using snake_case! I need to rework some scripts to follow this convention. Will test it later. Looks like you hardcode some paths. |
kRHYME7
reviewed
Dec 2, 2024
Comment on lines
1
to
2
| #!/usr/bin/env sh | ||
|
|
There was a problem hiding this comment.
Use bash in your shebang if the script is not POSIX (sh) at all, so the linters won't scream.
Suggested change
| #!/usr/bin/env sh | |
| #!/usr/bin/env bash | |
kRHYME7
reviewed
Dec 2, 2024
Comment on lines
4
to
13
| WALL_SCRIPT="$HOME/.local/share/bin/swwwallpaper.sh" | ||
| THEME_SCRIPT="$HOME/.local/share/bin/themeswitch.sh" | ||
| #SDDM_SCRIPT="$HOME/bin/setsddmwallpaper" | ||
| SDDM_SCRIPT="$HOME/.local/share/bin/setsddmwallpaper.sh" | ||
| LOG_FILE="$HOME/.local/share/cyclewallpaperandtheme.log" | ||
| WALL_CYCLE_FILE="$HOME/.local/share/cyclewallpapercount" | ||
| THEME_CYCLE_FILE="$HOME/.local/share/cyclethemecount" | ||
| THEME_CHANGE_FLAG_FILE="$HOME/.local/share/cyclethemeflag" | ||
| THEMES_DIR="$HOME/.config/hyde/themes" | ||
| HYDE_CONFIG="$HOME/.config/hyde/hyde.conf" |
There was a problem hiding this comment.
Too hardcoded, I will expose a global variables later and will use it so global stuff can be source/imported. Also don't put logs in .local/share.
Add the path to the script itself and source the global control to update the variable paths
|
@kRHYME7, I made changes based on your comments. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This pull aims to append two new scripts that can cycle through all installed wallpapers and themes and set them for the desktop and SDDM Corners theme. This is useful for those who want to see all wallpapers and themes they have installed or just is undecided on which one to use; for the latter, the user can set a cronjob to run the script periodically, thus having a new look on its PC from time to time.
(SDDM wallpaper will match the one on the desktop)
Type of change
Checklist