Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application and project tabs. #4196

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

frjo
Copy link
Contributor

@frjo frjo commented Nov 5, 2024

Fixes #4117

Test Steps

  • Check that the "Application" and "Project" tabs work and show up when they should.
  • Check that all links to the application from project side works as they should.
  • Is it ok to remove the simplified submission view?

@frjo frjo added Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter labels Nov 5, 2024
@frjo frjo force-pushed the enhancement/project_submission_tabs branch from f8ea6ad to d9422f1 Compare November 5, 2024 18:26
@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs user testing 👷 Tasks that should be tested by OTF's user test team labels Nov 5, 2024
@theskumar
Copy link
Member

theskumar commented Nov 6, 2024

Should these be updated as well?
Screenshot 2024-11-06 at 5  33 21@2x

Navigation Menu
Screenshot 2024-11-06 at 5  34 33@2x

On the submission all page:

Screenshot 2024-11-06 at 5  39 24@2x

@theskumar theskumar force-pushed the enhancement/project_submission_tabs branch from d9422f1 to bffc195 Compare November 6, 2024 05:48
@frjo
Copy link
Contributor Author

frjo commented Nov 7, 2024

Yes, we should likely update these strings as well for consistency.

There is an issue that this will break a number of translations that have been done in to Russian and Chinese.

I think best to tackle that in a separate PR.

@theskumar
Copy link
Member

Yes, we should likely update these strings as well for consistency.

There is an issue that this will break a number of translations that have been done in to Russian and Chinese.

I think best to tackle that in a separate PR.

make sense.

@frjo frjo force-pushed the enhancement/project_submission_tabs branch from bffc195 to d5e4ee4 Compare November 11, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs testing Tickets that need testing/qa Status: Needs user testing 👷 Tasks that should be tested by OTF's user test team Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Project" and "Submission" tabs on the submission and project detail pages
2 participants