Proposal stuck in draft when language code is set

[notaprodev]

When LANGUAGE_CODE is set to another language every application gets stuck in draft.

A separate issue is that the menu does not show if the applicant only have draft applications.

To Reproduce

Steps to reproduce the behavior:

1. Apply for a proposal
2. Fill the form
3. Click submit
4. The proposal stock in draft

Expected behavior

The form should go to review, even though a language is set on env vars
Priority

• High (keeping you from completing day-to-day tasks)

Affected roles

• Applicants

[frjo]

I can confirm this bug. Will get right on figuring out what the issue is. Thanks for reporting it!

[frjo]

I think the error is from this code:

hypha/hypha/apply/funds/views.py

Lines 1406 to 1418 in b9bd67e

	action = set(self.request.POST.keys()) & set(self.transitions.keys())
	try:
	transition = self.transitions[action.pop()]
	except KeyError:
	pass
	else:
	self.object.perform_transition(
	transition.target,
	self.request.user,
	request=self.request,
	notify=not (revision or submitting_proposal)
	or self.object.status == DRAFT_STATE, # Use the other notification
	)

The transition keys are translated but the post keys are not, so no match.

@theskumar Any ideas how to best solve this?

[frjo]

@notaprodev I do not recognise your name. Would love to hear how you are using Hypha!

We have online meetings where Hypha users discuss and share. Please join us at https://we.hypha.app/.

[notaprodev]

I work for cloud68.co an open source hosting provider, bugs reports are usually created by the support agents. One of our subscribers requested Hypha and after having a call with one of the main devs we deployed Hypha in production.

[frjo]

@notaprodev Thanks for the info! If possible, please let your customer know that we would very mush would like to hear from them, https://we.hypha.app/.

Will also definitely bookmark cloud68.co, we get request from funds that want to use Hypha and hosting is complicated if you do not have your own dev team.

[theskumar]

@notaprodev I've created a patch e6656d6 at #4220 please check if that resolves your issue.

[notaprodev]

Thanks for the patch. We will test it on our testing env and will let you know the result

[frjo]

@notaprodev This fix is now released as part of https://github.com/HyphaApp/hypha/releases/tag/v5.19.0

Thanks again for taking the time to report this! It took some time for us to get a fix in place but I believe it is a solid solution.