Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The method rhealpix_grid_as_geodataframe does not work for some resolutions #23

Open
rbejar opened this issue Mar 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@rbejar
Copy link
Contributor

rbejar commented Mar 13, 2024

It does not work for idx=5 and other resolutions (see DataTestsSpec.test_generate_rhealpix_grid). This appears to be due to some vertices from some cells falling out of the rhealpix "image". I am not sure where the problem is: some vertices of some cells in rHEALPix are actually outside of those cells. But the vertices operation in the Cell class, should take/is taking that into account? Is other thing?

The test avoids the problem but preventing the rhealpix library from doing some checks, but there should be a better solution (or at least we should be sure that we are creating the whole grid without errors).

@rbejar rbejar added the bug Something isn't working label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant