Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Pop-up Notification Icon Placement #75

Open
mpermann opened this issue Apr 3, 2022 · 1 comment
Open

[Feature Request] Pop-up Notification Icon Placement #75

mpermann opened this issue Apr 3, 2022 · 1 comment
Labels
enhancement New feature or request open to community An issue that will not be worked by IBM but is open for external developers

Comments

@mpermann
Copy link

mpermann commented Apr 3, 2022

Currently, the icon placement in the pop-up notification appears to have static constraints on the position of the icon. I would love to see an added "centered" option that centers the icon vertically based on the height of the text. I'd prefer it ignored the accessory view section should it be present and only center based on the text. I've attached some images of current behavior with and without accessory view and desired behavior with and without accessory view. Thanks for considering the enhancement.

Current Behavior

Current Behavior Accessory View

Desired Behavior

Desired Behavior Accessory View

@SMartorelli
Copy link
Member

Hi @mpermann, thanks for opening this FR. The current window layout for the Pop-up UI is based on the Catalina/Big Sur Apple HIG for Alerts (the current Apple HIG shows a different layout for Alerts that we're considering to integrate for "light" or "base" pop-ups) where the left icon for the alert was placed on the left side and anchored to the top constraint for the pop-up body. I think it makes the pop-up UI more consistent to not have the icon move up or down even because some of the accessory views could show simple text and that could make the position of the icon ambiguous if it only follow the "main" text elements of the pop-up.
That's why I think that we'll not consider to implement this logic.
I'll leave this FR open anyway so that if some developers from the community think that it's worth to work on it they can use this issue to track the deployment.
Thanks again for contributing to the community!

@SMartorelli SMartorelli changed the title Pop-up Notification Icon Placement [Feature Request] Pop-up Notification Icon Placement Apr 3, 2022
@SMartorelli SMartorelli added open to community An issue that will not be worked by IBM but is open for external developers enhancement New feature or request labels Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request open to community An issue that will not be worked by IBM but is open for external developers
Projects
None yet
Development

No branches or pull requests

2 participants