Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider keeping optimized connections copies per policy, in addition to copies per rules #542

Closed
tanyaveksler opened this issue Jun 27, 2023 · 1 comment
Assignees
Labels
Low prio Low priority issues

Comments

@tanyaveksler
Copy link
Member

Relates to PR #536
In order to support optimized implementation of RedundancyQuery, optimized properties are kept per each rule of policy. Optimized properties per policy are lazily evaluated from rules' properties at the first call of allowed_connections_optimized.
However, when changing a query, the domain of src_peers/dst_peers is changed, and optimized properties are rebuilt according to the new domain, while keeping copies of the original optimized properties. In this case, per policy properties should be recalculated, according to the updated rules' properties.
Possible optimization: consider keeping copies of per policy properties as well, to avoid their recalculation.

@tanyaveksler tanyaveksler self-assigned this Jun 27, 2023
@adisos adisos added the Low prio Low priority issues label Jan 14, 2024
@zivnevo
Copy link
Member

zivnevo commented Aug 1, 2024

Moved to NP-Guard repo. See here

@zivnevo zivnevo closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low prio Low priority issues
Projects
None yet
Development

No branches or pull requests

3 participants