New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queries with array parameters doesn't work #474

Open

Zn4rK opened this issue Sep 2, 2022 · 1 comment · May be fixed by #475

Zn4rK commented Sep 2, 2022

Describe the bug
Queries with query parameters that are array based doesn't work.

It boils down to this line:

openapi-to-graphql/packages/openapi-to-graphql/src/resolver_builder.ts

Line 1374 in 8951518

if (param.style === 'form' && typeof args[saneParamName] === 'object') {

An array is also considered an object in JavaScript. The if statement needs to be flipped.

Zn4rK linked a pull request

that will close this issue

Fix queries with array parameters #475

Open

Author

Zn4rK commented Sep 4, 2022

The queryString parts of that library should probably be handled by https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment