get_from_catalog does not return a fresh copy of the catalog object

[yoavkatz]

get_from_catalog does not return a fresh copy of the catalog object

   card = get_from_catalog("cards.banking77")
   card.task="...." 
   card = get_from_catalog("cards.banking77")
   /// same card object is returned from cache, and is the modified version

fetch_artifact returns a new value every time:

    card , _ = fetch_artifact("cards.banking77")
    card.task="...." 
     card , _ = fetch_artifact("cards.banking77")
     /// card is created a new, with the original task

[elronbandel]

A not fresh copy meaning it is effectively a singleton? not sure I understand

[dafnapension]

from unitxt.artifact import fetch_artifact
from unitxt.catalog import get_from_catalog


card1, _ = fetch_artifact("cards.banking77")
print(card1.task.metrics)  # prints ['metrics.f1_micro', 'metrics.accuracy', 'metrics.f1_macro']
card1.task.metrics = ['metrics.accuracy']
print(card1.task.metrics)  # prints ['metrics.accuracy']
card2, _ = fetch_artifact("cards.banking77")
print(card2.task.metrics)  # prints ['metrics.f1_micro', 'metrics.accuracy', 'metrics.f1_macro']

card3 = get_from_catalog("cards.banking77")
print(card3.task.metrics)  # prints ['metrics.f1_micro', 'metrics.accuracy', 'metrics.f1_macro']
card3.task.metrics = ['metrics.accuracy']
print(card3.task.metrics)  # prints ['metrics.accuracy']
card4 = get_from_catalog("cards.banking77")
print(card4.task.metrics)  # prints ['metrics.accuracy']

[dafnapension]

and it seems that the reason is the cache, that is only employed for get_from_catalog, and not for fetch_artifact:

[dafnapension]

Perhaps that cache needs to return a recursive copy of what it has to offer, like the ArtifactFetcherMixin