Improve filter settings User Interface

[kgruschow]

after selecting values, graph is not actually filtered or at least there is no clear UI for changing it. It can seem like filter is not being set, and it is not, user must check the box to turn on filter:

[miserman]

57c5f2b hopefully improves this.

[kgruschow]

That is an improvement, documenting related issues within that here:

The text label near the gear icon should make clear that the gear icon reveals filter/sort options for age_group or race. If possible it might be nice to literally label it as "Modify filter and settings for age_group" (or race respectively) . similarly, instead of 5/5 levels, 5/5 groups selected.

within those settings:

before literally asking almost everything to be changed... i think this is really good direction :)

1. sort by Increasing/decreasing - user needs to be able to clearly see that this is a control/ toggle. it will look worse but be more accessible (literally as well vis a vis section 508/ADA concerns)
2. the terms 'labels' and 'levels' are data science/statistics terms and should be avoided throughout the UI. Given the small number of variables, I think it is releastic to show specific names, e.g. instead of :
   it could say "include selected racial groups:", or if it were counties says "include selected counties:"
3. relatedly, the UI for selecting what "aspect" would preferably be something like "alphabetically by racial group" or alternately " by mean of arrests by racial group". note that mean should clearly state mean of it.
4. in same vein if that is done, likely the ordering of the top row would logically be "sort >alphabetically by group/numerically by mean> in ascending/descending order. This resolves some of the grammar issues created by this request.
5. the text for the exclusion should be altered to specifically state that is in addition to the above filter, e.g. if you select three racial groups and limits, it first keeps the selected groups and then excludes based on limits. Suggested terminology might be to "from the above selected groups, additionally filter out groups where:" or similar.
6. Is there a difference between close and X? it might be good to move the reset button elsewhere and have "submit" and "cancel" as lower buttons instead of close and reset. X should also cancel.

[miserman]

069620a makes I think all of these changes.

Relating to 6, I just removed the bottom close button for consistency. Currently everything is updated when any options are changed, so having submit and cancel buttons would involve making changes within that menu temporary, and only applying them if submit is clicked, which could be done, but would be a change from how other menus work.