-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Statewide accessibility requirements #6
Comments
One of the best ways to test is have a person who uses some of the related assistive tech to test. We have one (possibly two?) people who use visual assistive technology at ICJIA who could be approached to assist in testing. |
Moved to It's not See the
Google Lighthouse is a good first check -- but doesn't catch everything (unfortunately). If we need to talk more, please let me know. |
28b003c addresses some of this, but it will be an ongoing process. |
Thanks! Agreed -- it's ongoing. I appreciate it. The main a11y issues that I've noticed with Vuetify is that it (a) misses aria-labels on some components and (b) includes blank labels in My approach -- FWIW -- is to let Vuetify render the page and then -- after the I've been compiling a basic a11y "fix library" that I've been applying to various sites. Examples:
These aren't by any means comprehensive -- and they don't (yet, at least) fix 100% of the errors -- but based on the current status of Vuetify/Vue -- these seem to fix several of the critical issues raised by the |
BTW -- Here's the required accessibility script that DoIT recently asked agencies to add to public facing sites. I'm just appending to this to every
I'm still in the dark about when (or even if) they'll be scanning sites -- but I wanted to get everything ready (and easy to adjust if DoIT changes the script). |
57c5f2b adds this. |
Siteimprove indicates a labeling issue with v-combobox elements and the listboxes in v-select elements, but I wasn't able to immediately see how to fix them -- their input parts are labeled, and adding labels to other parts doesn't seem to fix it. |
I'll take a look on Monday. Which component has an example of the issue? EDIT: Here's Vuetify's page about a11y: https://vuetifyjs.com/en/features/accessibility/ In the 'item slots' section they indicate an issue (with what sounds like a workaround by utilizing the props) for the combobox and v-select. Does this sound viable in your case? |
src/components/Sheets/Export.vue has both, with the select one only showing up after it has been opened. But I'll play around with the template version. |
Thanks. I haven't checked out the error yet -- but is it possible to manually insert after the component has mounted? I've been doing that with several Vuetify-specific issues. Grab the offending element(s) post-render and either insert the aria label or (in the case of Vuetify's datatable) replace empty If it's something that can't be fixed or seems like it requires too much time -- please keep a list of the outstanding issues, and I'll cycle back at some point and submit a PR. The other a11y thing to check -- and you might already be doing this -- is the 'tabability' of the page -- i.e., hitting |
I played around with manually inserting labels for the select one, though it has to be inserted on click since the listbox isn't attached until then. The issue was that none of the label strategies I tried (those suggested by Siteimprove; parent Tabbing is currently a little weird since it goes into the data menu without opening it, and the ordering could probably be adjusted. I'm also planning on adjusting some of the structure labeling (like with aria landmarks) toward some of the best practices brought up by Siteimprove. |
I'm using this a checklist for manual checking: https://webaim.org/techniques/keyboard/ I've had the tab/menu issues as well -- and my focus (for now, at least) has been on the automated checkers -- Siteimprove, Lighthouse, and WebAim's 'Wave' checker. Wave seems to identify issues that Siteimprove misses and vice-versa. One approach -- especially with a dynamic interface like yours in the arrest-explorer -- might be to focus short-term on the critical errors in automatic checking -- and then, if and when necessary, cycle back for manual testing and fixes at a later date. I know the WCAG specs are in flux, as well -- so it's obviously an ongoing process. I've talked with several folks here -- as well as a few folks from DoIT -- and this seems to be a viable, mostly agreeable approach. And since your time is limited -- this probably makes the most sense for now. DoIT (AFAIK) still hasn't clarified -- or, at least, made public -- their own manual testing procedure. I'm assuming it's similar to the WebAim list above -- but it's hard to know for sure. |
de9985f should fix all of the issues brought up by Siteimprove, as well as Lighthouse and WAVE so far. The main labeling issue with the v-select and v-combobox elements was specific to their component with the listbox/combobox role, which didn't seem to be accessible using a template -- the things in a template go inside of this component. src/plugins/select_labeler.js adds labels to those elements. It is initially called in an I've also been playing with a screen reader (NVDA) a bit, and tried to better accommodate it, but that brought up some other issues I wasn't able to immediately fix:
I think at least everything can be tabbed to, and everything can be figured out verbally (other than the v-switches issue initially). |
From a little testing on an older Mac, Safari's audit (at least in version 13.1.2) flags some buttons as missing labels when they are in closed menus, similar to the Siteimprove issue with closed listboxes. It doesn't seem like a real issue, but might be something a checker flags. That browser also does not appropriately read the state of v-switches, similar to Firefox. d503516 removes the chips from the sort & filter menu's level select element, so that at least should be less annoying. |
Another issue to consider:
DoIT/CMS is mandating that all public-facing statewide websites meet current federal accessibility guidelines. I don't have a definitive word yet on the details of the mandate (i.e., if it's a legislative thing or a DoIT thing) -- but the a11y target appears to be current WCAG 2.1 guidelines.
The state is using an app called Siteimprove to check agency websites.
SiteImprove has a chrome extension that does a scan similar to their paid app. I'm using it as I develop and update the public sites.
It seems to identify quite a few (easily fixable) issues that Chrome's Lighthouse misses.
The text was updated successfully, but these errors were encountered: