Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

送金完了の通知 #60

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

送金完了の通知 #60

wants to merge 2 commits into from
+25 −10

Conversation

kiksun
Copy link

@kiksun kiksun commented Dec 10, 2018

関連Issue

close #55

やったこと

送金後に送金完了の通知を送るようにした。

実装の詳細

AppSend.jp内のsendDetermineの最後にalertを追加した。

レビューして欲しいところ

通知のデザインが変えるべきかどうか。

スクリーンショット

image

@kiksun kiksun changed the title Feature/iss55 送金完了通知画面の実装 Dec 10, 2018
@kiksun kiksun self-assigned this Dec 10, 2018
@kiksun kiksun added the enhancement New feature or request label Dec 10, 2018
@kiksun kiksun changed the title 送金完了通知画面の実装 送金完了の通知 Dec 10, 2018
tekoneko1997
tekoneko1997 reviewed Dec 10, 2018
View reviewed changes
Copy link
Contributor

@tekoneko1997 tekoneko1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

通知が送られる機能は良きだけど、modalの上にmodal　が重なるのはあんまりよくないかな

@kiksun
Copy link
Author

kiksun commented Dec 11, 2018

わかりました。
ただデータ送信後に動作する想定なので完成形では重ならないと思います。

tekoneko1997
tekoneko1997 requested changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@tekoneko1997 tekoneko1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

デザインは統一した方がいいかな

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekoneko1997 tekoneko1997 tekoneko1997 requested changes

@ShotaroOkada ShotaroOkada Awaiting requested review from ShotaroOkada

@tatsuika tatsuika Awaiting requested review from tatsuika

Requested changes must be addressed to merge this pull request.

Assignees

@tmrkw1497 tmrkw1497

@kiksun kiksun

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send画面での送信完了通知
3 participants
@kiksun @tekoneko1997 @tmrkw1497