-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add activation redirect #174
Merged
AdityaKhatri
merged 1 commit into
project/phase-2-dummy-pages
from
feature/account-activation
Nov 28, 2024
Merged
Add activation redirect #174
AdityaKhatri
merged 1 commit into
project/phase-2-dummy-pages
from
feature/account-activation
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roshni73
force-pushed
the
feature/account-activation
branch
from
November 26, 2024 06:43
4d30727
to
532c1cc
Compare
roshni73
force-pushed
the
feature/account-activation
branch
from
November 26, 2024 07:48
532c1cc
to
b66b2f6
Compare
roshni73
force-pushed
the
feature/account-activation
branch
from
November 26, 2024 08:58
b66b2f6
to
846b2b6
Compare
AdityaKhatri
requested changes
Nov 26, 2024
src/App/routes/index.tsx
Outdated
Comment on lines
258
to
270
// const resendValidationEmail = customWrapRoute({ | ||
// parent: rootLayout, | ||
// path: 'resend-validation-email', | ||
// component: { | ||
// render: () => import('#views/ResendValidationEmail'), | ||
// props: {}, | ||
// }, | ||
// wrapperComponent: Auth, | ||
// context: { | ||
// title: 'Resend Validation Email', | ||
// visibility: 'is-not-authenticated', | ||
// }, | ||
// }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use block comment.
src/App/routes/index.tsx
Outdated
wrapperComponent: Auth, | ||
context: { | ||
title: 'Activation Redirect', | ||
visibility: 'is-not-authenticated', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to anything
roshni73
force-pushed
the
feature/account-activation
branch
from
November 26, 2024 10:53
846b2b6
to
d50bff3
Compare
roshni73
force-pushed
the
feature/account-activation
branch
from
November 26, 2024 10:58
d50bff3
to
79696b2
Compare
AdityaKhatri
force-pushed
the
feature/account-activation
branch
from
November 26, 2024 12:10
79696b2
to
5fda585
Compare
AdityaKhatri
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
Changes
This PR doesn't introduce:
console.log
meant for debugging