Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take default Python version from NEST installation #25

Open
kappeld opened this issue May 8, 2018 · 2 comments
Open

Take default Python version from NEST installation #25

kappeld opened this issue May 8, 2018 · 2 comments

Comments

@kappeld
Copy link
Collaborator

kappeld commented May 8, 2018

I would suggest to change the default behavior of the installation script to take the Python version from the nest installation. nest-config recently introduced the feature to access the python version and path, so it should be quite easy to adapt the cmake script. Since in all practical cases the python version of SPORE and NEST should be the same this is more convenient for most users. We can still allow to overwrite the default using `-Dwith-python'.

see:

nest-config  --python-executable # print full path to Python interpreter used
nest-config  --python-version     # print Python version string for interpreter
@kappeld kappeld added this to the v2.16.0 milestone May 8, 2018
@mhoff
Copy link
Collaborator

mhoff commented May 8, 2018

Agreed. For the majority of users, if not for all of them, using the python version of NEST as default should be correct.

@kappeld
Copy link
Collaborator Author

kappeld commented May 8, 2018

Ok, great. I quickly tested this and implemented the following behavior:

  • The NEST version is now detected by cmake.
  • Python version is parsed from nest-config and overwrites the default.
  • if -Dwith-python is set it overwrites the default nest version.
  • if NEST is not found the installation aborts (we cannot even compile SPORE without a nest installation).
  • If NEST version is below minimum a warning is displayed but installation resumes.

I think this change makes the installation smoother but does not reduce the flexibility. We also have to adapt the REAMDE and wiki pages. I will make a PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants