Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal offset detection algorithm finds false positives for some URLs #88

Open
markmatney opened this issue May 3, 2023 · 0 comments

Comments

@markmatney
Copy link

markmatney commented May 3, 2023

In determining the "temporal offsets" for rendering a media element, the entire resource URI is matched against. However, this is problematic for URLs that coincidentally contain a t=<whatever> sequence in their path part, such as this one: https://wowza.library.ucla.edu/iiif_av_public/definst/mp4:soul/pairtree_root/21/19/8=/zz/00/2d/w1/7t/=8/q1/1h/04/9/21198=zz002dw17t=8q11h049/ark%2B=21198=zz002dw17t=8q11h049.mp4/manifest.mpd.

Attempting to load Universal Viewer 3.1.4 with a IIIF Presentation API manifest that references the above content resource results in an error state. Here is the top of the stack trace:

Uncaught TypeError: HTMLMediaElement.currentTime setter: Value being assigned is not a finite floating-point value.
    _setMediaCurrentTime IIIFAVComponent.js:1
    _synchronizeMedia IIIFAVComponent.js:1
    _updateMediaActiveStates IIIFAVComponent.js:1
    _lowPriorityUpdater IIIFAVComponent.js:1
    pause IIIFAVComponent.js:1
    _renderMediaElement IIIFAVComponent.js:1

Steps to reproduce:

  1. Spin up UCLALibrary/dl-viewer locally (http://localhost:8080 by default); depending on your Node version, you may need to set NODE_OPTIONS=--openssl-legacy-provider to work around ERR_OSSL_EVP_UNSUPPORTED
  2. Navigate to http://localhost:8080/#?manifest=https%3A%2F%2Fiiif.library.ucla.edu%2Fark%253A%252F21198%252Fzz002dw17t%2Fmanifest and observe the aforementioned error in the browser console log
  3. Navigate to http://localhost:8080/#?manifest=https%3A%2F%2Fiiif.library.ucla.edu%2Fark%253A%252F21198%252Fzz002dvx8f%2Fmanifest and observe the expected behavior for this resource type: rendering of audiowaveform data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant